Skip to content

Conversation

ericsyh
Copy link
Contributor

@ericsyh ericsyh commented Mar 12, 2025

Description

SubscriptionInitialPosition is the start consuming position for Pulsar subscription. Similar to Apache Kafka's initialOffset.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@ericsyh ericsyh requested review from a team as code owners March 12, 2025 15:54
Copy link
Contributor

@JoshVanL JoshVanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ericsyh! Please could you open up a PR in the docs for this new field?

Signed-off-by: ericsyh <[email protected]>
@ericsyh
Copy link
Contributor Author

ericsyh commented Mar 18, 2025

Thanks @ericsyh! Please could you open up a PR in the docs for this new field?

@JoshVanL Sure, i created the PR for doc update: dapr/docs#4582

@ericsyh ericsyh requested a review from JoshVanL March 19, 2025 01:18
@ericsyh
Copy link
Contributor Author

ericsyh commented Mar 25, 2025

@JoshVanL Hey Josh, Could you help give a reivew on this PR?

@cicoyle
Copy link
Contributor

cicoyle commented Mar 31, 2025

Hey @ericsyh thanks for the PR 🎉 - mind running the linter locally and resolving the issues?

ericsyh and others added 3 commits April 1, 2025 15:15
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Eric Shen <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Eric Shen <[email protected]>
Signed-off-by: ericsyh <[email protected]>
@ericsyh
Copy link
Contributor Author

ericsyh commented Apr 1, 2025

Hey @ericsyh thanks for the PR 🎉 - mind running the linter locally and resolving the issues?

@cicoyle Hi Cassie, thx for your review and good catches. I just fixed the tests and run the lint locally. At least this PR doesn't introduce new lint issue from the output.

WARN The linter 'gomnd' is deprecated (since v1.58.0) due to: The linter has been renamed. Replaced by mnd.
WARN The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner.
WARN [runner/nolint] Found unknown linters in //nolint directives: usetesting
pubsub/pulsar/pulsar.go:25:2                                                         typecheck  could not import sync/atomic (-: could not load export data: internal error in importing "sync/atomic" (unsupported version: 2); please report an issue)
pubsub/pulsar/pulsar.go:362:27                                                       typecheck  undefined: avro
pubsub/pulsar/pulsar.go:367:9                                                        typecheck  undefined: avro
make: *** [lint] Error 1

Signed-off-by: ericsyh <[email protected]>
@ericsyh
Copy link
Contributor Author

ericsyh commented Apr 13, 2025

@cicoyle @JoshVanL @yaron2 hey guys, could you help take a look this PR? Since this PR is pending for review and the related doc PR dapr/docs#4582 was closed for stale.

@yaron2
Copy link
Member

yaron2 commented Apr 24, 2025

@cicoyle @JoshVanL @yaron2 hey guys, could you help take a look this PR? Since this PR is pending for review and the related doc PR dapr/docs#4582 was closed for stale.

Yes, apologies for the slow feedback. Workflows now running

@ericsyh
Copy link
Contributor Author

ericsyh commented Apr 24, 2025

@cicoyle @JoshVanL @yaron2 hey guys, could you help take a look this PR? Since this PR is pending for review and the related doc PR dapr/docs#4582 was closed for stale.

Yes, apologies for the slow feedback. Workflows now running

@yaron2 Sure that's fine. The CI workflow check passed, could you help take a review on it?

@yaron2 yaron2 merged commit 4dfc9e5 into dapr:main Apr 29, 2025
90 checks passed
@ericsyh ericsyh deleted the support-pulsar-position branch April 30, 2025 01:28
jjcollinge pushed a commit to jjcollinge/components-contrib that referenced this pull request May 12, 2025
…pr#3700)

Signed-off-by: ericsyh <[email protected]>
Signed-off-by: Eric Shen <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Josh van Leeuwen <[email protected]>
@marcduiker
Copy link
Contributor

@holopin-bot @ericsyh Thank you! Here's a digital badge as a small token of appreciation.

Copy link

holopin-bot bot commented Jun 11, 2025

Congratulations @ericsyh, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbs0fdbg461407le4td1vc27

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants