-
Notifications
You must be signed in to change notification settings - Fork 542
feat(pulsar): support subscribeInitialPosition on Pulsar consumer #3700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: ericsyh <[email protected]>
@JoshVanL Sure, i created the PR for doc update: dapr/docs#4582 |
Signed-off-by: ericsyh <[email protected]>
@JoshVanL Hey Josh, Could you help give a reivew on this PR? |
Hey @ericsyh thanks for the PR 🎉 - mind running the linter locally and resolving the issues? |
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Eric Shen <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Eric Shen <[email protected]>
Signed-off-by: ericsyh <[email protected]>
@cicoyle Hi Cassie, thx for your review and good catches. I just fixed the tests and run the lint locally. At least this PR doesn't introduce new lint issue from the output. WARN The linter 'gomnd' is deprecated (since v1.58.0) due to: The linter has been renamed. Replaced by mnd.
WARN The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner.
WARN [runner/nolint] Found unknown linters in //nolint directives: usetesting
pubsub/pulsar/pulsar.go:25:2 typecheck could not import sync/atomic (-: could not load export data: internal error in importing "sync/atomic" (unsupported version: 2); please report an issue)
pubsub/pulsar/pulsar.go:362:27 typecheck undefined: avro
pubsub/pulsar/pulsar.go:367:9 typecheck undefined: avro
make: *** [lint] Error 1 |
Signed-off-by: ericsyh <[email protected]>
@cicoyle @JoshVanL @yaron2 hey guys, could you help take a look this PR? Since this PR is pending for review and the related doc PR dapr/docs#4582 was closed for stale. |
Yes, apologies for the slow feedback. Workflows now running |
@yaron2 Sure that's fine. The CI workflow check passed, could you help take a review on it? |
…pr#3700) Signed-off-by: ericsyh <[email protected]> Signed-off-by: Eric Shen <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Co-authored-by: Josh van Leeuwen <[email protected]>
@holopin-bot @ericsyh Thank you! Here's a digital badge as a small token of appreciation. |
Congratulations @ericsyh, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbs0fdbg461407le4td1vc27 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
SubscriptionInitialPosition
is the start consuming position for Pulsar subscription. Similar to Apache Kafka'sinitialOffset
.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: