feat(pulsar): support subscribeInitialPosition on Pulsar consumer #4582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ericsyh <[email protected]>
Merged
3 tasks
msfussell
reviewed
Mar 18, 2025
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-pulsar.md
Outdated
Show resolved
Hide resolved
…ubsub/setup-pulsar.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Eric Shen <[email protected]>
Contributor
Author
|
@msfussell thx for your review, apply the suggested change and update the same description on dapr/components-contrib@58599e0 |
|
Stale PR, paging all reviewers |
cicoyle
approved these changes
Mar 31, 2025
Contributor
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
PR here is still open, but docs updates lgtm
|
Stale PR, paging all reviewers |
cicoyle
requested changes
Apr 29, 2025
Contributor
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
@ericsyh actually, I think we will want to target the v1.16 docs branch. Can you update that?
Then cc @msfussell can you review?
cicoyle
added
the
waiting-on-code-pr
Contributor
Author
@cicoyle OK, let create a new PR based on the v1.16 branch and close this one. |
7 tasks
Contributor
Author
|
Close it since #4637 was merged on branch 1.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Update doc for dapr/components-contrib#3700
Issue reference