Skip to content

Conversation

javier-aliaga
Copy link
Contributor

@javier-aliaga javier-aliaga commented Jun 20, 2025

Description

Support new field taskExecutionId

Implements:

Depends on:

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@javier-aliaga javier-aliaga requested review from a team as code owners June 20, 2025 08:38
@mikeee mikeee marked this pull request as draft June 20, 2025 10:11
@mikeee
Copy link
Member

mikeee commented Jun 20, 2025

Drafting this until the upstream changes are merged and the deps vendored

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.16%. Comparing base (6c59092) to head (fa9290f).
⚠️ Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
client/conversation.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6c59092) and HEAD (fa9290f). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (6c59092) HEAD (fa9290f)
4 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   62.52%   57.16%   -5.36%     
==========================================
  Files          56       58       +2     
  Lines        4139     4436     +297     
==========================================
- Hits         2588     2536      -52     
- Misses       1425     1763     +338     
- Partials      126      137      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@javier-aliaga javier-aliaga force-pushed the execution-task-id branch 4 times, most recently from 2c78378 to b5283c5 Compare July 7, 2025 08:36
@javier-aliaga javier-aliaga reopened this Jul 7, 2025
@javier-aliaga javier-aliaga marked this pull request as ready for review July 14, 2025 09:00
@javier-aliaga
Copy link
Contributor Author

javier-aliaga commented Jul 14, 2025

Why codecov/project is failing? It is comparing with a very old commit (6c59092). Where is it configured?

@javier-aliaga javier-aliaga marked this pull request as draft July 14, 2025 09:32
@mikeee
Copy link
Member

mikeee commented Jul 14, 2025

I wouldn't worry too much about the pretty arbitary codecov, I can see the config hasn't been updated for 5 years in the root of the repo.

@mikeee mikeee marked this pull request as ready for review August 6, 2025 17:11
mikeee
mikeee previously approved these changes Aug 6, 2025
Signed-off-by: Javier Aliaga <[email protected]>
@javier-aliaga javier-aliaga force-pushed the execution-task-id branch 2 times, most recently from 224740a to 0f8cf61 Compare August 7, 2025 11:22
Signed-off-by: Javier Aliaga <[email protected]>
@javier-aliaga
Copy link
Contributor Author

@mikeee this is ready and running with rc3

Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please open a quick issue if you don't have time to add the new Alpha2 implementation of the conversation api jsut so we're not ignoring the planned deprecation entirelyCould you please open a quick issue if you don't have time to add the new Alpha2 implementation of the conversation api jsut so we're not ignoring the planned deprecation entirely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javier-aliaga
Copy link
Contributor Author

@mikeee can we merge this?

@yaron2 yaron2 merged commit 99b259f into dapr:main Aug 7, 2025
4 checks passed
@mikeee mikeee added this to the v1.13 milestone Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants