protein_mpnn_utils.py cleanup #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 14, 2022 14:17
atoms shouldn't have a list as a default arg, since it's mutable and could cause problems. also added type annotations
- use string instead of manually defining alphabet - remove unused loop - use isinstance instead of type() - rename my_dict -> pdb_dict - remove unused variables - use f-string instead of str concat - use join instead of iterative string concat - add type annotation
Seanny123
force-pushed
the
utils-cleanup
branch
from
f5a7ce3 to
504482c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup a few issues detected by
pylintand refactoredparse_PDBto be more succinct. This MR does increase the requirements to Python 3.10, but I can remove the type annotations if you want more version flexibility.I can also provide further refactorings, if desired, such as:
protein_mpnn_utils.pyto be imported in the helper scriptsprotein_mpnn_utils.pyintoutils.pyandmodels.pypylintwarnings, such as unused variables and imports