Fix PARTITION BY placement in CREATE ICEBERG TABLE for built-in catalog#1726
Open
jecolvin wants to merge 2 commits intodbt-labs:mainfrom
Open
Fix PARTITION BY placement in CREATE ICEBERG TABLE for built-in catalog#1726jecolvin wants to merge 2 commits intodbt-labs:mainfrom
jecolvin wants to merge 2 commits intodbt-labs:mainfrom
Conversation
Move PARTITION BY clause to appear immediately after column definitions, before EXTERNAL_VOLUME/CATALOG/BASE_LOCATION, matching Snowflake's required CREATE ICEBERG TABLE syntax. Closes dbt-labs#1720
jecolvin
force-pushed
the
fix/iceberg-partition-by-ordering
branch
from
9f027de to
df378fb
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes the generated Snowflake CREATE ICEBERG TABLE DDL for built-in catalogs by placing the PARTITION BY clause in the correct location per Snowflake’s required syntax, and adds a regression assertion to ensure clause ordering stays correct.
Changes:
- Move
PARTITION BYto immediately follow column definitions in the built-in catalog Iceberg table creation macro. - Add an integration-test assertion verifying
partition byappears beforeexternal_volume. - Add an unreleased “Fixes” changelog entry for the bugfix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
dbt-snowflake/src/dbt/include/snowflake/macros/relations/table/create.sql |
Reorders built-in Iceberg DDL to place PARTITION BY before EXTERNAL_VOLUME/CATALOG/BASE_LOCATION. |
dbt-snowflake/tests/functional/iceberg/test_iceberg_partition_by.py |
Adds an ordering assertion to prevent regression in generated DDL. |
dbt-snowflake/.changes/unreleased/Fixes-20260306-163035.yaml |
Records the fix in unreleased changelog metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PARTITION BYclause to appear immediately after column definitions, beforeEXTERNAL_VOLUME/CATALOG/BASE_LOCATION, matching Snowflake's required CREATE ICEBERG TABLE syntaxTest plan
test_iceberg_partition_by.py) validated in CI (requires Snowflake Iceberg infrastructure)Closes #1720