Skip to content

Fix PARTITION BY placement in CREATE ICEBERG TABLE for built-in catalog #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jecolvin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix PARTITION BY placement in CREATE ICEBERG TABLE for built-in catalog #1726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df378fb
Fix PARTITION BY placement in CREATE ICEBERG TABLE for built-in catalog
jecolvin Mar 6, 2026
73a8920
Potential fix for pull request finding
jecolvin Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dbt-snowflake/.changes/unreleased/Fixes-20260306-163035.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Fix PARTITION BY clause placement in CREATE ICEBERG TABLE DDL for Snowflake built-in catalog
time: 2026-03-06T16:30:35.728134-05:00
custom:
Author: jecolvin
Issue: "1720"
2 changes: 1 addition & 1 deletion dbt-snowflake/src/dbt/include/snowflake/macros/relations/table/create.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,10 @@ create or replace iceberg table {{ relation }}
{%- if contract_config.enforced %}
{{ get_table_columns_and_constraints() }}
{%- endif %}
{% if partition_by_string -%} partition by ({{ partition_by_string }}) {%- endif %}
{{ optional('external_volume', catalog_relation.external_volume, "'") }}
catalog = 'SNOWFLAKE' -- required, and always SNOWFLAKE for built-in Iceberg tables
base_location = '{{ catalog_relation.base_location }}'
{% if partition_by_string -%} partition by ({{ partition_by_string }}) {%- endif %}
{{ optional('storage_serialization_policy', catalog_relation.storage_serialization_policy, "'")}}
{{ optional('max_data_extension_time_in_days', catalog_relation.max_data_extension_time_in_days)}}
{{ optional('data_retention_time_in_days', catalog_relation.data_retention_time_in_days)}}
Expand Down
2 changes: 2 additions & 0 deletions dbt-snowflake/tests/functional/iceberg/test_iceberg_partition_by.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,8 @@ def test_partition_by_iceberg_builtin_catalog(self, project, setup_class):
run_dbt(["run"])
iceberg_sql = get_cleaned_model_ddl_from_file("builtin_table.sql")
assert "partition by (order_date)" in iceberg_sql
# partition by must appear before external_volume per Snowflake syntax
assert iceberg_sql.index("partition by") < iceberg_sql.index("external_volume")


class TestPartitionByIcebergRestCatalog(TestIcebergPartitionBy):
Expand Down
Loading