Skip to content

Added missing **kwargs to DroneTrackingModule and OsmSkill __init__#2345

Open
knikou01 wants to merge 3 commits into
dimensionalOS:mainfrom
knikou01:fix/drone-agentic-missing-kwargs
Open

Added missing **kwargs to DroneTrackingModule and OsmSkill __init__#2345
knikou01 wants to merge 3 commits into
dimensionalOS:mainfrom
knikou01:fix/drone-agentic-missing-kwargs

Conversation

@knikou01
Copy link
Copy Markdown

@knikou01 knikou01 commented Jun 3, 2026

Fixed drone-agentic blueprint failing to start due to missing **kwargs in DroneTrackingModule and OsmSkill init methods.

Both modules defined init without **kwargs, causing autoconnect() to fail when passing graph wiring arguments at deploy time.

Fixed: TypeError: DroneTrackingModule.init() got an unexpected keyword argument 'g'
Fixed: TypeError: OsmSkill.init() got an unexpected keyword argument 'g'

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 3, 2026

Greptile Summary

This PR fixes a deployment failure in the drone-agentic blueprint by adding **kwargs forwarding to two module __init__ methods — DroneTrackingModule and OsmSkill. Without this, autoconnect() could not pass graph-wiring arguments (such as g) to either module at deploy time.

  • OsmSkill: __init__ previously took no arguments; now accepts and forwards **kwargs: Any to Module.__init__, matching the framework's expected calling convention.
  • DroneTrackingModule: Same pattern applied to the existing multi-parameter __init__; **kwargs is appended as the last parameter and forwarded to super().__init__(**kwargs).
  • Both changes are minimal, consistent with each other, and align with how other Module subclasses in the codebase handle autoconnect wiring.

Confidence Score: 5/5

Safe to merge — both changes are minimal, correct, and targeted fixes to a known deployment crash.

Both modules now correctly forward unknown keyword arguments to the base Module.init, which is all that is needed for autoconnect() to wire graph arguments at deploy time. The change introduces no new logic, no new state, and no new external dependencies. The existing constructor behavior for DroneTrackingModule named parameters is fully preserved.

No files require special attention.

Important Files Changed

Filename Overview
dimos/agents/skills/osm.py Adds **kwargs: Any to OsmSkill.init and forwards them to super().init(**kwargs), fixing autoconnect wiring failures. Change is correct and complete.
dimos/robot/drone/drone_tracking_module.py Adds **kwargs: Any to DroneTrackingModule.init signature and forwards them to super().init(**kwargs). Docstring not updated to mention **kwargs, but otherwise correct.

Sequence Diagram

sequenceDiagram
    participant AC as autoconnect()
    participant DTM as DroneTrackingModule
    participant OSM as OsmSkill
    participant MOD as Module (base)

    Note over AC: Deploy time - graph wiring args passed to each module

    AC->>DTM: "DroneTrackingModule(outdoor=False, g=graph_wire)"
    DTM->>MOD: "super().__init__(**kwargs)"
    MOD-->>DTM: initialized with wiring

    AC->>OSM: "OsmSkill(g=graph_wire)"
    OSM->>MOD: "super().__init__(**kwargs)"
    MOD-->>OSM: initialized with wiring

    Note over AC,MOD: Previously: TypeError on unknown kwarg 'g'
Loading

Reviews (2): Last reviewed commit: "Update dimos/agents/skills/osm.py" | Re-trigger Greptile

Comment thread dimos/agents/skills/osm.py Outdated
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant