Added missing **kwargs to DroneTrackingModule and OsmSkill __init__#2345
Added missing **kwargs to DroneTrackingModule and OsmSkill __init__#2345knikou01 wants to merge 3 commits into
Conversation
Greptile SummaryThis PR fixes a deployment failure in the drone-agentic blueprint by adding
Confidence Score: 5/5Safe to merge — both changes are minimal, correct, and targeted fixes to a known deployment crash. Both modules now correctly forward unknown keyword arguments to the base Module.init, which is all that is needed for autoconnect() to wire graph arguments at deploy time. The change introduces no new logic, no new state, and no new external dependencies. The existing constructor behavior for DroneTrackingModule named parameters is fully preserved. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant AC as autoconnect()
participant DTM as DroneTrackingModule
participant OSM as OsmSkill
participant MOD as Module (base)
Note over AC: Deploy time - graph wiring args passed to each module
AC->>DTM: "DroneTrackingModule(outdoor=False, g=graph_wire)"
DTM->>MOD: "super().__init__(**kwargs)"
MOD-->>DTM: initialized with wiring
AC->>OSM: "OsmSkill(g=graph_wire)"
OSM->>MOD: "super().__init__(**kwargs)"
MOD-->>OSM: initialized with wiring
Note over AC,MOD: Previously: TypeError on unknown kwarg 'g'
Reviews (2): Last reviewed commit: "Update dimos/agents/skills/osm.py" | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Fixed drone-agentic blueprint failing to start due to missing **kwargs in DroneTrackingModule and OsmSkill init methods.
Both modules defined init without **kwargs, causing autoconnect() to fail when passing graph wiring arguments at deploy time.
Fixed: TypeError: DroneTrackingModule.init() got an unexpected keyword argument 'g'
Fixed: TypeError: OsmSkill.init() got an unexpected keyword argument 'g'