REFACTOR: Remove getType() override to allow extensibility#21
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the getType() method override from ElementCard to improve extensibility. By inheriting BaseElement::getType(), sites can now customize the element's display name through the $singular_name configuration property rather than requiring method overrides.
Key Changes:
- Removed hardcoded
getType()method override that returned a static 'Card' translation - Element now inherits base implementation which uses the existing
$singular_nameproperty
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
getType()method override so the element inheritsBaseElement::getType()which usesi18n_singular_name(). This allows sites to customize the element's display name via extensions by setting$singular_name.Changes
getType()method fromElementCardRationale
The base
BaseElement::getType()implementation already uses$this->i18n_singular_name():By removing the override, extensions can now customize the display name in the CMS element picker by simply setting
$singular_name, without needing to override the entire method.Fixes #20
Related: dynamic/silverstripe-essentials-tools#68