REFACTOR: Remove getType() override to allow extensibility

[jsirish]

Summary

Remove the getType() method override so the element inherits BaseElement::getType() which uses i18n_singular_name(). This allows sites to customize the element's display name via extensions by setting $singular_name.

Changes

• Removed the getType() method from ElementTestimonials
• Updated $singular_name from 'Testimonials Element' to 'Testimonials'
• Updated $plural_name from 'Testimonials Elements' to 'Testimonials Blocks'

Rationale

The base BaseElement::getType() implementation already uses $this->i18n_singular_name():

public function getType()
{
    $default = $this->i18n_singular_name() ?: 'Block';
    return _t(static::class . '.BlockType', $default);
}

By removing the override, extensions can now customize the display name in the CMS element picker by simply setting $singular_name, without needing to override the entire method.

Fixes #31

Related: dynamic/silverstripe-essentials-tools#68

[Copilot]

Pull request overview

This refactoring removes a hardcoded getType() method override to enable extensibility. By removing the override, the element now inherits BaseElement::getType() which retrieves the display name from i18n_singular_name(), allowing sites to customize the element's display name via extensions without overriding methods.

• Removed hardcoded getType() method to leverage base class implementation
• Updated $singular_name to 'Testimonials' to maintain consistent display name
• Updated $plural_name to 'Testimonials Blocks' for list views

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The singular and plural names appear inconsistent. If $singular_name is 'Testimonials' (already in plural form), then $plural_name should logically also be 'Testimonials' for consistency. Alternatively, consider $singular_name = 'Testimonials Block' and $plural_name = 'Testimonials Blocks' to follow standard singular/plural conventions where the plural adds an 's' to the singular form.