Skip to content

REFACTOR: Remove getType() override to allow extensibility #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsirish merged 1 commit into from
Dec 2, 2025
Merged

REFACTOR: Remove getType() override to allow extensibility #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/Elements/ElementTestimonials.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ class ElementTestimonials extends BaseElement
/**
* @var string
*/
private static $singular_name = 'Testimonials Element';
private static $singular_name = 'Testimonials';

/**
* @var string
*/
private static $plural_name = 'Testimonials Elements';
private static $plural_name = 'Testimonials Blocks';
Comment on lines +32 to +37
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The singular and plural names appear inconsistent. If $singular_name is 'Testimonials' (already in plural form), then $plural_name should logically also be 'Testimonials' for consistency. Alternatively, consider $singular_name = 'Testimonials Block' and $plural_name = 'Testimonials Blocks' to follow standard singular/plural conventions where the plural adds an 's' to the singular form.

Copilot uses AI. Check for mistakes.

/**
* @var string
Expand Down Expand Up @@ -95,14 +95,6 @@ protected function provideBlockSchema()
return $blockSchema;
}

/**
* @return string
*/
public function getType()
{
return _t(__CLASS__ . '.BlockType', 'Testimonials');
}

/**
* @return FieldList
*/
Expand Down