feat: allow SS4 and SS5 compatibility, add phpcs#220
Conversation
- Allow recipe-cms ^4.0 || ^5.0 for backward compatibility - Allow gridfieldextensions ^3.0 || ^4.0 - Allow linkable ^1.0 || ^2.0 - Add squizlabs/php_codesniffer to require-dev - Remove dev-master and repository config (using released versions)
There was a problem hiding this comment.
Pull request overview
This PR updates the module to support both SilverStripe 4 and SilverStripe 5, adds PHP_CodeSniffer as a development dependency, and removes the custom VCS repository configuration for the dynamic/silverstripe-linkable package.
Changes:
- Updated dependency constraints to support both SS4 and SS5 using the
||operator pattern - Added
squizlabs/php_codesniffer: ^3.7as a development dependency for code quality checks - Removed custom VCS repository configuration, indicating the package is now available on Packagist
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "type": "vcs", | ||
| "url": "git@github.com:dynamic/silverstripe-linkable.git" | ||
| } | ||
| "silverstripe/recipe-testing": "^3", |
There was a problem hiding this comment.
The constraint silverstripe/recipe-testing: ^3 may not be compatible with both SilverStripe 4 and 5. According to the SilverStripe versioning scheme, silverstripe/recipe-testing: ^2 is typically used for SilverStripe 4, while ^3 is used for SilverStripe 5. To support both SS4 and SS5 as intended by this PR, the constraint should be ^2.0 || ^3.0 to match the pattern used for the other dependencies.
| "silverstripe/recipe-testing": "^3", | |
| "silverstripe/recipe-testing": "^2.0 || ^3.0", |
- Require recipe-cms ^5.0 (SS5 only) - Require gridfieldextensions ^4.0 (SS5 compatible) - Require linkable ^2.0 (SS5 compatible)
No description provided.