Skip to content

feat: allow SS4 and SS5 compatibility, add phpcs #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsirish wants to merge 2 commits into from
Closed

feat: allow SS4 and SS5 compatibility, add phpcs #220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b061fb4
feat: allow SS4 and SS5 compatibility, add phpcs
jsirish Feb 2, 2026
d872b1f
fix: require SS5 only
jsirish Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,13 @@
}
],
"require": {
"dynamic/silverstripe-linkable": "dev-master",
"silverstripe/recipe-cms": "^5",
"symbiote/silverstripe-gridfieldextensions": "^4"
"dynamic/silverstripe-linkable": "^2.0",
"silverstripe/recipe-cms": "^5.0",
"symbiote/silverstripe-gridfieldextensions": "^4.0"
},
"require-dev": {
"silverstripe/recipe-testing": "^3"
},
"repositories": {
"dynamic/silverstripe-linkable": {
"type": "vcs",
"url": "git@github.com:dynamic/silverstripe-linkable.git"
}
"silverstripe/recipe-testing": "^3",
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constraint silverstripe/recipe-testing: ^3 may not be compatible with both SilverStripe 4 and 5. According to the SilverStripe versioning scheme, silverstripe/recipe-testing: ^2 is typically used for SilverStripe 4, while ^3 is used for SilverStripe 5. To support both SS4 and SS5 as intended by this PR, the constraint should be ^2.0 || ^3.0 to match the pattern used for the other dependencies.

Suggested change
"silverstripe/recipe-testing": "^3",
"silverstripe/recipe-testing": "^2.0 || ^3.0",

Copilot uses AI. Check for mistakes.
"squizlabs/php_codesniffer": "^3.7"
},
"minimum-stability": "dev",
"prefer-stable": true,
Expand Down