Remove the safety mutex in Reception in Thread Pool #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jparisu <[email protected]>
Codecov ReportBase: 58.45% // Head: 58.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
+ Coverage 58.45% 58.60% +0.14%
==========================================
Files 99 99
Lines 3428 3423 -5
Branches 1277 1272 -5
==========================================
+ Hits 2004 2006 +2
+ Misses 649 647 -2
+ Partials 775 770 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
juanlofer-eprosima
requested changes
Sep 22, 2022
| Task& task = it->second; | ||
|
|
||
| logDebug(DDSROUTER_THREAD_POOL, "Thread: " << std::this_thread::get_id() << " executing callback."); | ||
| task(); |
There was a problem hiding this comment.
I would say that the time taken for copying a function (in our case, only with functions whose args are not copied) is not so relevant. However, it might be problematic to have the discovery thread stuck for not being able to slot a new task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jparisu [email protected]