Add alerts visualization #272
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
…ecly displayed Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
emiliocuestaf
force-pushed
the
feature/add-alerts
branch
from
d5984c8 to
c2c0b1e
Compare
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Danipiza
reviewed
Oct 8, 2025
|
It would be great to add the ability to edit or delete existing alerts.
|
Signed-off-by: Emilio Cuesta <[email protected]>
Danipiza
requested changes
Oct 8, 2025
Danipiza
requested changes
Oct 8, 2025
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Finally I think edit alert can be left for a future PR as it is not critical. I totally agree with its convenience but there are probably other priorities RN |
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Danipiza
requested changes
Oct 9, 2025
Danipiza
reviewed
Oct 9, 2025
Co-authored-by: DannyP39 <[email protected]> Signed-off-by: Emilio Cuesta Fernandez <[email protected]>
Co-authored-by: DannyP39 <[email protected]> Signed-off-by: Emilio Cuesta Fernandez <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Danipiza
previously approved these changes
Oct 10, 2025
Signed-off-by: Emilio Cuesta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive support for alert management within the Fast DDS Monitor application. The changes span backend, model, and controller layers, enabling the system to define, trigger, process, and display alerts and their messages.
THIS PR DEPENDS ON https://github.com/eProsima/Fast-DDS-statistics-backend/pull/290/files AND MUST BE MERGED AFTER IT