-
Notifications
You must be signed in to change notification settings - Fork 5
[#23686] Support "partitions" in DDS-spy #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Danipiza
wants to merge
16
commits into
main
Choose a base branch
from
feature/partition-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
…rtitions filter Signed-off-by: danipiza <[email protected]>
…command Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
ad96673
to
5022731
Compare
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
Signed-off-by: danipiza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a filter by partitions feature in Fast-DDS-Spy. By creating a filter list, the Spy will only show the information that matches with the partitions filter added by the user.
With the commands written below, you can specify the filters. In each command the DataReaders stored in the Tracks of the DdsPipe are updated with the partitions. If a Topic does not contains a partition from the filter, the readers will not have any partition assigned (this do not include the empty partition) and the endpoint in the database will be disabled until it matches with the filter.
Contributor Checklist
Reviewer Checklist