Skip to content

Conversation

zesk1999
Copy link
Contributor

@zesk1999 zesk1999 commented Oct 7, 2025

Description

Previously, topic data printed by Fast DDS Spy was heavily indented and multiline, making long arrays and nested objects verbose and harder to read at a glance.

Solution

This PR reformats the printed JSON to be more compact and readable by:

  • Keeping arrays on a single line
  • Retaining object indentation and valid JSON structure
  • Avoiding unnecessary newlines to make payloads shorter and clearer

The change only affects output formatting, not the data content or serialization logic.

Copy link

@Danipiza Danipiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just optimizing performance

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.46%. Comparing base (6dacfed) to head (07e7f63).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
fastddsspy_tool/src/cpp/tool/Controller.cpp 0.00% 45 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6dacfed) and HEAD (07e7f63). Click for more details.

HEAD has 76 uploads less than BASE
Flag BASE (6dacfed) HEAD (07e7f63)
77 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   60.71%   55.46%   -5.25%     
==========================================
  Files          27       26       -1     
  Lines        1718     1381     -337     
  Branches      706      530     -176     
==========================================
- Hits         1043      766     -277     
- Misses        299      317      +18     
+ Partials      376      298      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zesk1999 zesk1999 changed the title Refs #23757. Formatting the output. [23757] Formatting the output Oct 9, 2025
@zesk1999 zesk1999 force-pushed the hotfix/new_lines_output branch from 824bd34 to 324fcfe Compare October 9, 2025 13:51
@zesk1999 zesk1999 force-pushed the hotfix/new_lines_output branch from 324fcfe to 55ed623 Compare October 9, 2025 15:13
@zesk1999 zesk1999 force-pushed the hotfix/new_lines_output branch 4 times, most recently from c75ebf8 to 8ace4bd Compare October 9, 2025 15:31
@zesk1999 zesk1999 requested review from Danipiza and removed request for Danipiza October 10, 2025 06:00
@Danipiza Danipiza self-requested a review October 10, 2025 06:45
Signed-off-by: zesk1999 <[email protected]>
@rsanchez15 rsanchez15 merged commit ed01338 into main Oct 13, 2025
16 of 19 checks passed
@rsanchez15 rsanchez15 deleted the hotfix/new_lines_output branch October 13, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants