Skip to content

Conversation

fujitatomoya
Copy link
Contributor

@fujitatomoya fujitatomoya commented Jun 9, 2025

Description

Closes ros2/rmw_fastrtps#789

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@fujitatomoya
Copy link
Contributor Author

http://jenkins.eprosima.com:8080/job/fastdds_github_uncrustify/13245/ returns ERR_CONNECTION_RESET, can anyone form eProsima check the jenkins status?

@MiguelCompany MiguelCompany self-requested a review June 9, 2025 05:35
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for MiguelCompany and richiprosima June 9, 2025 05:48
@MiguelCompany MiguelCompany changed the title clip min_low_mark to handle the acked changes properly. [23207] clip min_low_mark to handle the acked changes properly. Jun 9, 2025
@MiguelCompany
Copy link
Member

@fujitatomoya Thanks for opening this PR. Don't worry about the linter, it is failing in lines you didn't change.

It would be nice if you could add a regression test for this.

@fujitatomoya
Copy link
Contributor Author

@MiguelCompany it is hard for me to find the appropriate place where to add the regression test... if you can point the existed similar test cases aligned with this PR, that would be really appreciated.

Copy link
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw thanks for the fix 👍 that was fix for v2.6.x branch... sorry

@MiguelCompany MiguelCompany self-requested a review June 10, 2025 06:59
@fujitatomoya
Copy link
Contributor Author

@MiguelCompany friendly ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SHM transport: The longer it runs, The more latency increases. (Buffer Full Exception)

2 participants