-
Notifications
You must be signed in to change notification settings - Fork 866
[23207] clip min_low_mark to handle the acked changes properly. #5859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Tomoya Fujita <[email protected]>
http://jenkins.eprosima.com:8080/job/fastdds_github_uncrustify/13245/ returns ERR_CONNECTION_RESET, can anyone form eProsima check the jenkins status? |
@fujitatomoya Thanks for opening this PR. Don't worry about the linter, it is failing in lines you didn't change. It would be nice if you could add a regression test for this. |
@MiguelCompany it is hard for me to find the appropriate place where to add the regression test... if you can point the existed similar test cases aligned with this PR, that would be really appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw thanks for the fix 👍 that was fix for v2.6.x branch... sorry
…ocessed. Signed-off-by: Tomoya Fujita <[email protected]>
@MiguelCompany friendly ping. |
Description
Closes ros2/rmw_fastrtps#789
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist