Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 11, 2025

Description

This PR improves latency tests by removing Log Filters and fixing the test destruction. It also adds configuration for the reliable tests.

This will not be backported to 2.14 as the performance test suite is different from the one used in Fast DDS 3.x

@Mergifyio backport 3.3.x 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5998 done by [Mergify](https://mergify.com).

@mergify mergify bot mentioned this pull request Sep 11, 2025
10 tasks
@cferreiragonz cferreiragonz added this to the v3.2.3 milestone Sep 11, 2025
@MiguelCompany
Copy link
Member

@Mergifyio rebase

* Refs #23482: Remove Log filter

Signed-off-by: cferreiragonz <[email protected]>

* Refs #23482: Fix destruction of latency tests

Signed-off-by: cferreiragonz <[email protected]>

* Refs #23482: Make reliable tests keep_all with allocated resources

Signed-off-by: cferreiragonz <[email protected]>

Use keep_all history

Signed-off-by: cferreiragonz <[email protected]>

Alloc resources

Signed-off-by: cferreiragonz <[email protected]>

* Refs #23482: Apply changes to udp too

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit b39ed87)
@MiguelCompany MiguelCompany force-pushed the mergify/bp/3.2.x/pr-5998 branch from 76bf9d9 to 7219e6b Compare October 10, 2025 08:55
@mergify
Copy link
Contributor Author

mergify bot commented Oct 10, 2025

rebase

✅ Branch has been successfully rebased

@MiguelCompany MiguelCompany self-requested a review October 10, 2025 08:56
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 10, 2025
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@mergify
Copy link
Contributor Author

mergify bot commented Oct 10, 2025

🧪 CI Insights

Here's what we observed from your CI run for 7219e6b.

❌ Job Failures

Pipeline Job Health on 3.2.x Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View

@MiguelCompany MiguelCompany merged commit cdd01d5 into 3.2.x Oct 12, 2025
27 of 28 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.2.x/pr-5998 branch October 12, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants