Skip to content

Conversation

@b8raoult
Copy link
Collaborator

@b8raoult b8raoult commented Nov 6, 2025

Description

What problem does this change solve?

What issue or task does this change relate to?

Additional notes

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

@github-project-automation github-project-automation bot moved this to To be triaged in Anemoi-dev Nov 6, 2025
@github-actions github-actions bot added the enhancement New feature or request label Nov 6, 2025
class UserProvidedForcings(Forcings):
trace_name = "user_provided"

def __init__(self, context: Context, forcings, variables: list[str], mask: IntArray):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can forcings be type hinted?

"""Use that runner when using the low level API."""

def __init__(self, *args: Any, **kwargs: Any) -> None:
def __init__(self, *args: Any, forcings: dict[str, Any] | None = None, **kwargs: Any) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is any here correct?

@HCookie HCookie moved this from To be triaged to Under Review in Anemoi-dev Nov 17, 2025
@HCookie
Copy link
Member

HCookie commented Nov 17, 2025

Do we want to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Under Review

Development

Successfully merging this pull request may close these issues.

3 participants