-
Notifications
You must be signed in to change notification settings - Fork 32
Remove EcalEndcapPInsert #1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove EcalEndcapPInsert #1852
Conversation
for more information, see https://pre-commit.ci
Yes, please remove those and other instances too.
There are codes in |
I have created a pull request for this just now; see eic/detector_benchmarks#151 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good in the diff
(Let's wait to see if there more comments and merge Tomorrow, otherwise.) |
Briefly, what does this PR introduce?
Remove EcalEndcapPInsert since it will not be built.
See : eic/epic#855 for removing it from geometry.
I'm not sure if I should remove it from :
EICrecon/src/services/io/podio/JEventProcessorPODIO.cc
Line 255 in c9ea43d
EICrecon/.github/janadot.groups
Line 7 in c9ea43d
How can I remove it from auto checks?
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No more EcalEndcapPInsert
Does this PR change default behavior?
No more EcalEndcapPInsert