Randomise the query order in the MS Marco V2 param supplier#1025
Open
davidkyle wants to merge 1 commit intoelastic:masterfrom
Open
Randomise the query order in the MS Marco V2 param supplier#1025davidkyle wants to merge 1 commit intoelastic:masterfrom
davidkyle wants to merge 1 commit intoelastic:masterfrom
Conversation
john-wagster
reviewed
Feb 9, 2026
| for vector_query in queries_file: | ||
| self._queries.append(json.loads(vector_query)) | ||
|
|
||
| self._queries = random.shuffle(self._queries) |
Contributor
There was a problem hiding this comment.
I wonder if it makes sense to allow a settable seed for the sake of reproducing the shuffle ordering and then printing the seed in the logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a challenge contains many search operations using this supplier and the supplier is recreated each time then the same hot vectors at the beginning of the file will be used every time. This change shuffles the vectors read from the file.