Skip to content

Randomise the query order in the MS Marco V2 param supplier #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidkyle wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Randomise the query order in the MS Marco V2 param supplier #1025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions msmarco-v2-vector/track.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import csv
import json
import os
import random
import statistics
from collections import defaultdict
from typing import Any, Dict, List
Expand Down Expand Up @@ -86,6 +87,8 @@ def __init__(self, track, params, **kwargs):
with bz2.open(os.path.join(cwd, QUERIES_FILENAME), "r") as queries_file:
for vector_query in queries_file:
self._queries.append(json.loads(vector_query))

self._queries = random.shuffle(self._queries)
Copy link
Contributor

@john-wagster john-wagster Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it makes sense to allow a settable seed for the sake of reproducing the shuffle ordering and then printing the seed in the logs.

self._iters = 0
self._maxIters = len(self._queries)
self.infinite = True
Expand Down