stm32/i2c: remove busy waiting on BUSY flag in v2 #4877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahu-wm
force-pushed
the
fix-i2c-async-blocking
branch
from
5c37796 to
3a207a6
Compare
mahu-wm
force-pushed
the
fix-i2c-async-blocking
branch
from
3a207a6 to
abcf740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blocking wait is already not present in the master_read function, and the comment
The START bit can be set even if the bus is BUSY or I2C is in slave modea few lines below already contradicts its necessity.I consider it a partial fix for #2299, but only one of the blocking loops is removed.