Skip to content

stm32/i2c: remove busy waiting on BUSY flag in v2 #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

stm32/i2c: remove busy waiting on BUSY flag in v2 #4877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions embassy-stm32/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- fix: Avoid generating timer update events when updating the frequency ([#4890](https://github.com/embassy-rs/embassy/pull/4890))
- chore: cleanup low-power add time
- fix: Allow setting SAI peripheral `frame_length` to `256`
- fix: stm32/i2c fix busy waiting on BUSY flag in v2
- fix: flash erase on dual-bank STM32Gxxx
- feat: Add support for STM32N657X0
- feat: timer: Add 32-bit timer support to SimplePwm waveform_up method following waveform pattern ([#4717](https://github.com/embassy-rs/embassy/pull/4717))
Expand Down
6 changes: 0 additions & 6 deletions embassy-stm32/src/i2c/v2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,7 @@ impl<'d, M: Mode, IM: MasterMode> I2c<'d, M, IM> {
while info.regs.cr2().read().start() {
timeout.check()?;
}

// Wait for the bus to be free
while info.regs.isr().read().busy() {
timeout.check()?;
}
}

// Set START and prepare to send `bytes`. The
// START bit can be set even if the bus is BUSY or
// I2C is in slave mode.
Expand Down