Skip to content

Conversation

apellerano-pw
Copy link

Version 1.2.0 of the codemod is failing to parse render-invoked helpers, e.g.

<div
  {{(if this.flag (modifier "my-foo"))}}
></div>

For conditional modifiers, this syntax must be used. If you omit the extra parenthesis in {{()}} ember will not compile the template.

I tried bumping ember-template-recast from v3 to v6 and it fixed this issue.

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@meirish
Copy link

meirish commented Jul 30, 2025

I thought it might be useful to others who run into this since the PR isn't merged yet. You can run the codemod from the fork and this branch by doing this:

npx github:apellerano-pw/ember-component-template-colocation-migrator#major-bump-ember-template-recast-v3-to-v6

Thanks for this!

NullVoxPopuli
NullVoxPopuli previously approved these changes Aug 5, 2025
@NullVoxPopuli
Copy link
Contributor

looks like in order to use this upgrade, some other maintenance needs to happen first

@NullVoxPopuli NullVoxPopuli dismissed their stale review August 5, 2025 20:50

not ready for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants