Skip to content

fix: proxy more parts of fetch Response#519

Merged
NullVoxPopuli merged 3 commits intoemberjs:masterfrom
Techn1x:bo/improve-fetch-response-proxy
Jul 5, 2025
Merged

fix: proxy more parts of fetch Response#519
NullVoxPopuli merged 3 commits intoemberjs:masterfrom
Techn1x:bo/improve-fetch-response-proxy

Conversation

@Techn1x
Copy link
Copy Markdown
Contributor

@Techn1x Techn1x commented Jun 13, 2025

resolves #518

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Jul 4, 2025
@NullVoxPopuli
Copy link
Copy Markdown
Contributor

Sorry it took me so long to get to this -- I forgot :(

Can you address the type issue? thanks!!

@Techn1x
Copy link
Copy Markdown
Contributor Author

Techn1x commented Jul 4, 2025

All good!

Oops, yeah will fix the type issue tomorrow. (2am here :P )

@Techn1x
Copy link
Copy Markdown
Contributor Author

Techn1x commented Jul 5, 2025

I've gone a bit further than asked;

  • fixed the type issue, and ensured that the property names we're using are indeed properties of Response class, by using type guards
  • added some code comments. I tend to over-comment so please let me know if I should reduce them.
  • added response body property to list of properties

Probably a little more challenging to review now, sorry!

@NullVoxPopuli

@NullVoxPopuli NullVoxPopuli merged commit 03d3f94 into emberjs:master Jul 5, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Jul 5, 2025
@Techn1x
Copy link
Copy Markdown
Contributor Author

Techn1x commented Jul 10, 2025

FYI @mfeckie - we can remove some ember/test-waiters pnpm patches we have with this update in the 4.1.1 release. Shoot me a message if it causes trouble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve waitForFetch proxy

2 participants