-
Notifications
You must be signed in to change notification settings - Fork 336
Removing dependency on org.graalvm.collections module
#14574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdunkerley
requested changes
Jan 7, 2026
Member
jdunkerley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but a few changes please
...table/src/main/java/org/enso/table/util/CaseInsensitiveUnicodeNormalizedTextEquivalence.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/org/enso/table/util/CaseInsensitiveUnicodeNormalizedTextEquivalence.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/org/enso/table/util/CaseInsensitiveUnicodeNormalizedTextEquivalence.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/util/NameDeduplicator.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/util/NameDeduplicator.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/util/UnicodeNormalizedTextEquivalence.java
Outdated
Show resolved
Hide resolved
Co-authored-by: James Dunkerley <[email protected]>
964271f to
434909b
Compare
Co-authored-by: James Dunkerley <[email protected]>
Co-authored-by: James Dunkerley <[email protected]>
jdunkerley
approved these changes
Jan 8, 2026
.../table/src/main/java/org/enso/table/util/CaseInsensitiveUnicodeNormalizedTextComparator.java
Show resolved
Hide resolved
3f661ad to
ba0f31d
Compare
9a169c0 to
f1cb385
Compare
Akirathan
approved these changes
Jan 8, 2026
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-compiler
-libs
Libraries: New libraries to be implemented
-libs-API-change-Table
Marks a PR that changes the public API of Standard.Table
CI: Clean build required
CI runners will be cleaned before and after this PR is built.
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Pairusage from engine in 063c533Map.EntryandSimpleEntryinstead in most of the casesPairfromstd-base: a2f8234EconomicMap& co. fromstd-table: 7b71468Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,