Skip to content

Conversation

@JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jan 7, 2026

Pull Request Description

  • removes Pair usage from engine in 063c533
  • using Map.Entry and SimpleEntry instead in most of the cases
  • removing Pair from std-base: a2f8234
  • removing EconomicMap & co. from std-table: 7b71468

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
  • Unit tests continue to work

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 7, 2026
@JaroslavTulach JaroslavTulach requested a review from 4e6 as a code owner January 7, 2026 06:08
@JaroslavTulach JaroslavTulach added the -libs Libraries: New libraries to be implemented label Jan 7, 2026
@JaroslavTulach JaroslavTulach self-assigned this Jan 7, 2026
@JaroslavTulach JaroslavTulach moved this to 🔧 Implementation in Issues Board Jan 7, 2026
@JaroslavTulach JaroslavTulach moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jan 7, 2026
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but a few changes please

@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🔴 Changes requested in Issues Board Jan 7, 2026
@JaroslavTulach JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jan 8, 2026
@github-actions github-actions bot added the -libs-API-change-Table Marks a PR that changes the public API of Standard.Table label Jan 8, 2026
@github-project-automation github-project-automation bot moved this from 🔴 Changes requested to 🟢 Accepted in Issues Board Jan 8, 2026
@JaroslavTulach JaroslavTulach reopened this Jan 8, 2026
@github-project-automation github-project-automation bot moved this from 🟢 Accepted to 🌟 Q/A review in Issues Board Jan 8, 2026
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Jan 8, 2026
@mergify mergify bot merged commit 615fc90 into develop Jan 8, 2026
149 of 151 checks passed
@mergify mergify bot deleted the wip/jtulach/NoPair branch January 8, 2026 18:18
@github-project-automation github-project-automation bot moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Jan 8, 2026
@enso-bot enso-bot bot mentioned this pull request Jan 9, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-compiler -libs Libraries: New libraries to be implemented -libs-API-change-Table Marks a PR that changes the public API of Standard.Table CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge

Projects

Status: 🟢 Accepted

Development

Successfully merging this pull request may close these issues.

3 participants