Add range test cases for Min/Max Create/Mod revision #21180
Conversation
Signed-off-by: Nont <nont@duck.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nwnt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@nwnt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 26 files with indirect coverage changes @@ Coverage Diff @@
## main #21180 +/- ##
==========================================
+ Coverage 68.39% 68.42% +0.03%
==========================================
Files 429 429
Lines 35288 35288
==========================================
+ Hits 24135 24146 +11
+ Misses 9758 9753 -5
+ Partials 1395 1389 -6 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| {begin: "c", options: config.GetOptions{Revision: int(firstRev) + 3}, wantResponse: &clientv3.GetResponse{Header: createHeader(firstRev + 7), Count: 1, Kvs: []*mvccpb.KeyValue{kvCV2}}}, | ||
| {begin: "c", options: config.GetOptions{Revision: int(firstRev) + 4}, wantResponse: &clientv3.GetResponse{Header: createHeader(firstRev + 7), Count: 1, Kvs: []*mvccpb.KeyValue{kvC}}}, | ||
| {begin: "c", wantResponse: &clientv3.GetResponse{Header: createHeader(firstRev + 7), Count: 1, Kvs: []*mvccpb.KeyValue{kvC}}}, | ||
| {begin: "", options: config.GetOptions{Prefix: true, MinModRevision: int(firstRev) + 2, MaxModRevision: int(firstRev) + 6}, wantResponse: &clientv3.GetResponse{Header: createHeader(firstRev + 7), Count: 6, Kvs: []*mvccpb.KeyValue{kvC, kvFoo, kvFooAbc}}}, |
There was a problem hiding this comment.
Could you set and evaluate min/max create/mod revision individually? Also please add some sorting
| {begin: "c", options: config.GetOptions{Revision: int(firstRev) + 4}, wantResponse: &clientv3.GetResponse{Header: createHeader(firstRev + 7), Count: 1, Kvs: []*mvccpb.KeyValue{kvC}}}, | ||
| {begin: "c", wantResponse: &clientv3.GetResponse{Header: createHeader(firstRev + 7), Count: 1, Kvs: []*mvccpb.KeyValue{kvC}}}, | ||
| {begin: "", options: config.GetOptions{Prefix: true, MinModRevision: int(firstRev) + 2, MaxModRevision: int(firstRev) + 6}, wantResponse: &clientv3.GetResponse{Header: createHeader(firstRev + 7), Count: 6, Kvs: []*mvccpb.KeyValue{kvC, kvFoo, kvFooAbc}}}, | ||
| {begin: "", options: config.GetOptions{Prefix: true, MinModRevision: int(firstRev), MaxModRevision: int(firstRev) + 7}, wantResponse: &clientv3.GetResponse{Header: createHeader(firstRev + 7), Count: 6, Kvs: allKvs}}, |
There was a problem hiding this comment.
Could you maybe add description to each scenario?
There was a problem hiding this comment.
Yep, I added the description for the existing test cases with #21187. Once that's ok and merged, I'll update the tests introduced in this PR accordingly.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Should be the final set of coverage for range.
cc @serathius