Add description for range tests #21187
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #21187 +/- ##
==========================================
+ Coverage 68.38% 68.46% +0.07%
==========================================
Files 429 429
Lines 35288 35288
==========================================
+ Hits 24132 24160 +28
+ Misses 9759 9737 -22
+ Partials 1397 1391 -6 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nwnt, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| {name: "Get third version of 'c' by its revision", begin: "c", options: config.GetOptions{Revision: int(firstRev) + 4}, wantResponse: &clientv3.GetResponse{Header: createHeader(firstRev + 7), Count: 1, Kvs: []*mvccpb.KeyValue{kvC}}}, | ||
| {name: "Get the latest version of 'c'", begin: "c", wantResponse: &clientv3.GetResponse{Header: createHeader(firstRev + 7), Count: 1, Kvs: []*mvccpb.KeyValue{kvC}}}, | ||
| } | ||
| for _, tt := range tests { |
There was a problem hiding this comment.
Please use names to create subtests.
There was a problem hiding this comment.
Yep, done. Planned to do that but then totally forgot..
nwnt
force-pushed
the
add-range-test-description
branch
from
981ce21 to
6b4098b
Compare
Signed-off-by: Nont <nont@duck.com>
nwnt
force-pushed
the
add-range-test-description
branch
from
6b4098b to
0b9b5be
Compare
|
@nwnt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
sorry just saw that I introduced a bug unintentionally. should be ok now;1 @serathius. |
3 participants
As discussed in #21180
#21180 (comment)
cc @serathius