Skip to content

Conversation

@jpople
Copy link
Contributor

@jpople jpople commented Jan 16, 2026

Ticket ENG-2413

Description Of Changes

Fixes two UX issues in the updated custom field form:

  • "Template" field is now marked as required, so submissions won't be accepted without either selecting a taxonomy for the field type or a custom field config
  • Template no longer requires a name to be entered to configure (name is still required to submit form)

Steps to Confirm

  1. Go to custom fields form
  2. Enter a name and don't select a template; press "save", should see error
  3. Delete the name and select "Custom" for the template; should be able to select a field type and location without entering a name (form will still not submit until name is entered)

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@jpople jpople requested a review from a team as a code owner January 16, 2026 22:29
@jpople jpople requested review from speaker-ender and removed request for a team January 16, 2026 22:29
@vercel
Copy link
Contributor

vercel bot commented Jan 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Error Error Jan 16, 2026 10:29pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 16, 2026 10:29pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 16, 2026

Greptile Summary

This PR implements two UX fixes for the custom field form:

  1. Template field now required: Added validation to ensure users must select a template (either "Custom" or a taxonomy option) before submission. This prevents incomplete field configurations.

  2. Name no longer blocks template configuration: Removed the !!name && condition that previously required entering a name before displaying custom field type and location options. Users can now configure these settings without entering a name first, though the form still requires a name for final submission.

The changes are minimal, focused, and directly address the issues described in the PR. The implementation maintains form integrity (name is still required to submit) while improving the configuration workflow.

Confidence Score: 5/5

  • This PR is safe to merge with no concerns.
  • The PR makes two straightforward, well-justified UX improvements to the custom field form with minimal code changes. Both modifications directly address the requirements in the ticket: adding template validation and removing the name dependency for displaying configuration options. The form logic remains sound - the name field still has required validation and the form won't submit without it. No complex logic changes, no security concerns, and no risk of introducing bugs.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/custom-fields/CustomFieldForm.tsx UX improvements to custom field form: (1) Added required validation to Template field to ensure users select either a taxonomy or custom field type, (2) Removed name requirement for displaying custom field configuration options, allowing users to configure field type and location before entering a name. Form still requires name for submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants