Skip to content

UX fixes for custom field form #7242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpople wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UX fixes for custom field form #7242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions clients/admin-ui/src/features/custom-fields/CustomFieldForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,16 @@ const CustomFieldForm = ({
<Input.TextArea rows={2} data-testid="input-description" />
</Form.Item>

<Form.Item label="Template" name="template">
<Form.Item
label="Template"
name="template"
rules={[
{
required: true,
message: "Select a template",
},
]}
>
<Select
options={[
{ label: "Custom", value: CUSTOM_TEMPLATE_VALUE },
Expand Down Expand Up @@ -269,7 +278,7 @@ const CustomFieldForm = ({
/>
</Form.Item>

{!!name && selectedTemplate === CUSTOM_TEMPLATE_VALUE && (
{selectedTemplate === CUSTOM_TEMPLATE_VALUE && (
<>
<Form.Item
label="Field type"
Expand Down
Loading