Better Offline resize handling #110
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proper error when trying to resize volume.
Return properly FAILED_PRECODITION: https://github.com/kubernetes-csi/external-resizer/blob/f28f38ba2a7a3375c279d041973ddcb1d76e9bc4/pkg/controller/controller.go#L681
I also added a Podman build file. I could not use Docker for licensing reasons and the Docker Podman compatibility layer does not support buildX.
Without buildx or (in podman)
--platformparameter, resizing does not work fully when the container was compiled on Mac, because then the ext4 resize tools are then in ARM64 form and make an error. (So the GOARCH parameter is not enough, the container itself has to use amd64).Checklist
(For exoscale contributors)
Testing
Testing Steps:
Test logs:
VolumeResizeFailed will still loop, but use the kubernetes backing off timer, which should be fine.