Change save_gltf_from_skel_states to save_gltf_with_skel_states. #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

cdtwigg wants to merge 1 commit into main from export-D82411872

Contributor

cdtwigg commented Sep 15, 2025

Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

meta-cla bot added the CLA Signed label

Contributor

facebook-github-bot commented Sep 15, 2025

@cdtwigg has exported this pull request. If you are a Meta employee, you can view the originating diff in D82411872.

facebook-github-bot added fb-exported meta-exported labels

facebook-github-bot pushed a commit that referenced this pull request


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

d037713

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

cdtwigg added a commit that referenced this pull request


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

21ab1a4

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

cdtwigg added a commit that referenced this pull request


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

b397c10

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

cdtwigg force-pushed the export-D82411872 branch from a4b3cba to b397c10 Compare

September 16, 2025 05:21

Contributor

facebook-github-bot commented Sep 16, 2025

@cdtwigg has exported this pull request. If you are a Meta employee, you can view the originating diff in D82411872.

cdtwigg added a commit that referenced this pull request


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

e43dc01

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

cdtwigg force-pushed the export-D82411872 branch from b397c10 to e43dc01 Compare

September 16, 2025 21:30

Contributor

facebook-github-bot commented Sep 16, 2025

@cdtwigg has exported this pull request. If you are a Meta employee, you can view the originating diff in D82411872.

cdtwigg added a commit that referenced this pull request


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

6c379c0

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

cdtwigg added a commit that referenced this pull request


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

9ee173f

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

cdtwigg added a commit that referenced this pull request


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

76a2317

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

cdtwigg force-pushed the export-D82411872 branch from e43dc01 to 76a2317 Compare

September 17, 2025 19:35

Contributor

facebook-github-bot commented Sep 17, 2025

@cdtwigg has exported this pull request. If you are a Meta employee, you can view the originating diff in D82411872.

cdtwigg added a commit that referenced this pull request


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

02d7ad8

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

cdtwigg force-pushed the export-D82411872 branch from 76a2317 to 02d7ad8 Compare

September 18, 2025 23:38

Contributor

facebook-github-bot commented Sep 18, 2025

@cdtwigg has exported this pull request. If you are a Meta employee, you can view the originating diff in D82411872.

cdtwigg added a commit that referenced this pull request


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

511fc10

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

cdtwigg added a commit that referenced this pull request


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

fb5edb5

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

cdtwigg force-pushed the export-D82411872 branch from 02d7ad8 to fb5edb5 Compare

September 22, 2025 18:32

cdtwigg added a commit that referenced this pull request


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

141815e

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

Contributor

facebook-github-bot commented Sep 22, 2025

@cdtwigg has exported this pull request. If you are a Meta employee, you can view the originating diff in D82411872.

facebook-github-bot pushed a commit that referenced this pull request


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

9f443f5

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

facebook-github-bot force-pushed the export-D82411872 branch from fb5edb5 to 9f443f5 Compare

September 22, 2025 19:57

Contributor

facebook-github-bot commented Sep 22, 2025

@cdtwigg has exported this pull request. If you are a Meta employee, you can view the originating diff in D82411872.


          Change save_gltf_from_skel_states to save_gltf_with_skel_states. (#569)

394d1e9

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872

cdtwigg force-pushed the export-D82411872 branch from 9f443f5 to 394d1e9 Compare

September 26, 2025 05:09

Contributor

facebook-github-bot commented Sep 26, 2025

@cdtwigg has exported this pull request. If you are a Meta employee, you can view the originating diff in D82411872.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported meta-exported