Change save_gltf_from_skel_states to save_gltf_with_skel_states.#569
Open
Change save_gltf_from_skel_states to save_gltf_with_skel_states.#569
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 15, 2025
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
cdtwigg
added a commit
that referenced
this pull request
Sep 16, 2025
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
cdtwigg
added a commit
that referenced
this pull request
Sep 16, 2025
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
cdtwigg
force-pushed
the
export-D82411872
branch
from
a4b3cba to
b397c10
Compare
Contributor
cdtwigg
added a commit
that referenced
this pull request
Sep 16, 2025
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
cdtwigg
force-pushed
the
export-D82411872
branch
from
b397c10 to
e43dc01
Compare
Contributor
cdtwigg
added a commit
that referenced
this pull request
Sep 16, 2025
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
cdtwigg
added a commit
that referenced
this pull request
Sep 17, 2025
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
cdtwigg
added a commit
that referenced
this pull request
Sep 17, 2025
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
cdtwigg
force-pushed
the
export-D82411872
branch
from
e43dc01 to
76a2317
Compare
Contributor
cdtwigg
added a commit
that referenced
this pull request
Sep 18, 2025
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
cdtwigg
force-pushed
the
export-D82411872
branch
from
76a2317 to
02d7ad8
Compare
Contributor
cdtwigg
added a commit
that referenced
this pull request
Sep 18, 2025
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
cdtwigg
added a commit
that referenced
this pull request
Sep 22, 2025
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
cdtwigg
force-pushed
the
export-D82411872
branch
from
02d7ad8 to
fb5edb5
Compare
cdtwigg
added a commit
that referenced
this pull request
Sep 22, 2025
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 22, 2025
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
facebook-github-bot
force-pushed
the
export-D82411872
branch
from
fb5edb5 to
9f443f5
Compare
Contributor
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
cdtwigg
force-pushed
the
export-D82411872
branch
from
9f443f5 to
394d1e9
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.
Reviewed By: jeongseok-meta
Differential Revision: D82411872