Enable PyPI publishing #725
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
jeongseok-meta
changed the title
jeongseok-meta
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
jeongseok-meta
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
|
Pending #727 |
jeongseok-meta
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
jeongseok-meta
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
jeongseok-meta
had a problem deploying
to
pypi-cpu
GitHub Actions
Error
|
@jeongseok-meta has imported this pull request. If you are a Meta employee, you can view this in D85481027. |
jeongseok-meta
added a commit
that referenced
this pull request
Oct 25, 2025
Summary: This PR enables building wheel files for pymomentum and publishing to PyPI ([`pymomentum-gpu`](https://pypi.org/project/pymomentum-gpu/) and [`pymomentum-cpu`](https://pypi.org/project/pymomentum-cpu/)). * New PyPI workflow with CPU/GPU wheel builds * Template-based config system for platform-specific PyTorch versions * CI cost optimizations (concurrency control, Python 3.13 skipping) * Ubuntu CUDA 12.9.0 installer workaround * Disk space optimization for GPU builds * Comprehensive documentation added ## Checklist: - [x] Adheres to the [style guidelines](https://facebookresearch.github.io/momentum/docs/developer_guide/style_guide) - [x] Codebase formatted by running `pixi run lint` Pull Request resolved: #725 Test Plan: * CI wheel builds (no publishing) * CI publish to PyPI on git tag * Local testing with pixi commands (e.g., `pixi run -e py313 build_pypi_wheel`) Differential Revision: D85481027 Pulled By: jeongseok-meta
jeongseok-meta
force-pushed
the
pypi_pub
branch
from
077e673 to
aa7a0bc
Compare
|
@jeongseok-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85481027. |
jeongseok-meta
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
Summary: This PR enables building wheel files for pymomentum and publishing to PyPI ([`pymomentum-gpu`](https://pypi.org/project/pymomentum-gpu/) and [`pymomentum-cpu`](https://pypi.org/project/pymomentum-cpu/)). * New PyPI workflow with CPU/GPU wheel builds * Template-based config system for platform-specific PyTorch versions * CI cost optimizations (concurrency control, Python 3.13 skipping) * Ubuntu CUDA 12.9.0 installer workaround * Disk space optimization for GPU builds * Comprehensive documentation added ## Checklist: - [x] Adheres to the [style guidelines](https://facebookresearch.github.io/momentum/docs/developer_guide/style_guide) - [x] Codebase formatted by running `pixi run lint` Pull Request resolved: #725 Test Plan: https://fb.workplace.com/groups/1222607168126483/permalink/2638230143230838/ * CI wheel builds (no publishing) * CI publish to PyPI on git tag * Local testing with pixi commands (e.g., `pixi run -e py313 build_pypi_wheel`) Differential Revision: D85481027 Pulled By: jeongseok-meta
jeongseok-meta
force-pushed
the
pypi_pub
branch
from
aa7a0bc to
71985fe
Compare
jeongseok-meta
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
jeongseok-meta
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
jeongseok-meta
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
jeongseok-meta
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
|
@jeongseok-meta merged this pull request in 7d62e53. |
2 tasks
meta-codesync bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
…els (#738) Summary: PyPI was rejecting Linux wheels with [error](https://github.com/facebookresearch/momentum/actions/runs/18853730732/job/53797928855): `Binary wheel 'pymomentum_cpu-0.1.81.post0-cp312-cp312-linux_x86_64.whl' has an unsupported platform tag 'linux_x86_64'.` PyPI requires Linux wheels to use `manylinux` tags (e.g., `manylinux_2_17_x86_64`) instead of generic `linux_x86_64` for cross-distribution compatibility. The `build_pypi_repair` task was already defined in `pixi.toml` since PR #725, but the CI workflow never called it. This wasn't caught because: * CI builds wheels successfully without publishing (no PyPI validation) * First actual PyPI publish attempt revealed the issue Added `build_pypi_repair` step to CI workflow after building wheels on Linux: * Runs `auditwheel repair` to convert `linux_x86_64` → `manylinux_*` tags * Removes original wheel after repair * Skipped on macOS (not needed) ## Checklist: - [ ] Adheres to the [style guidelines](https://facebookresearch.github.io/momentum/docs/developer_guide/style_guide) - [ ] Codebase formatted by running `pixi run lint` Pull Request resolved: #738 Test Plan: Next PyPI publish should succeed with properly tagged `manylinux` wheels. Reviewed By: nickyhe-gemini Differential Revision: D85597200 Pulled By: jeongseok-meta fbshipit-source-id: 10eb68baa893f5e5d31ddab61f8d55deb39df71d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables building wheel files for pymomentum and publishing to PyPI (
pymomentum-gpuandpymomentum-cpu).Usage
With uv (preferred):
With pip:
Checklist:
pixi run lintTest Plan
pixi run -e py313 build_pypi_wheel)