Add missing axel dependency to tensor_momentum #727
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@jeongseok-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85474531. |
jeongseok-meta
added a commit
that referenced
this pull request
Oct 24, 2025
Summary: Fix linking error when importing geometry from pymomentum PyPI package: ``` Python 3.12.11 (main, Sep 2 2025, 14:20:58) [Clang 20.1.4 ] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import pymomentum.geometry Traceback (most recent call last): File "<stdin>", line 1, in <module> ImportError: /home/jeongseok/dev/tmp/.venv/lib/python3.12/site-packages/pymomentum/geometry.cpython-312-x86_64-linux-gnu.so: undefined symbol: _ZTVN4axel3BvhIdLm4EEE ``` This was not caught by any of the CI, which is odd but could happen with different compiler settings. Reviewed By: cdtwigg Differential Revision: D85474531
jeongseok-meta
force-pushed
the
export-D85474531
branch
from
1191a68 to
b29120c
Compare
jeongseok-meta
added a commit
that referenced
this pull request
Oct 25, 2025
Summary: Pull Request resolved: #727 Fix linking error when importing geometry from pymomentum PyPI package: ``` Python 3.12.11 (main, Sep 2 2025, 14:20:58) [Clang 20.1.4 ] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import pymomentum.geometry Traceback (most recent call last): File "<stdin>", line 1, in <module> ImportError: /home/jeongseok/dev/tmp/.venv/lib/python3.12/site-packages/pymomentum/geometry.cpython-312-x86_64-linux-gnu.so: undefined symbol: _ZTVN4axel3BvhIdLm4EEE ``` This was not caught by any of the CI, which is odd but could happen with different compiler settings. Reviewed By: cdtwigg Differential Revision: D85474531
jeongseok-meta
force-pushed
the
export-D85474531
branch
from
b29120c to
79a5da8
Compare
jeongseok-meta
added a commit
that referenced
this pull request
Oct 25, 2025
Summary: Pull Request resolved: #727 Fix linking error when importing geometry from pymomentum PyPI package: ``` Python 3.12.11 (main, Sep 2 2025, 14:20:58) [Clang 20.1.4 ] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import pymomentum.geometry Traceback (most recent call last): File "<stdin>", line 1, in <module> ImportError: /home/jeongseok/dev/tmp/.venv/lib/python3.12/site-packages/pymomentum/geometry.cpython-312-x86_64-linux-gnu.so: undefined symbol: _ZTVN4axel3BvhIdLm4EEE ``` This was not caught by any of the CI, which is odd but could happen with different compiler settings. Reviewed By: cdtwigg Differential Revision: D85474531
jeongseok-meta
force-pushed
the
export-D85474531
branch
from
79a5da8 to
4ef804a
Compare
jeongseok-meta
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
jeongseok-meta
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
jeongseok-meta
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
jeongseok-meta
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
…oad the correct commit data. Differential Revision: D85488266
Summary: Fixed incorrect template-id syntax in the destructor definition of `MultiposeSolverFunctionT<T>`. The destructor was incorrectly defined as `~MultiposeSolverFunctionT<T>()` but should be `~MultiposeSolverFunctionT()` per C++ standard - template-ids are not allowed after the destructor operator. This error was caught by conda-forge builds but not by Meta's internal diff signals because the external pymomentum CI job is currently disabled in GitHub workflows to reduce costs, and internal Buck builds apparently succeed with different compiler flags. Differential Revision: D85457060
jeongseok-meta
added a commit
that referenced
this pull request
Oct 25, 2025
Summary: Pull Request resolved: #727 Fix linking error when importing geometry from pymomentum PyPI package: ``` Python 3.12.11 (main, Sep 2 2025, 14:20:58) [Clang 20.1.4 ] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import pymomentum.geometry Traceback (most recent call last): File "<stdin>", line 1, in <module> ImportError: /home/jeongseok/dev/tmp/.venv/lib/python3.12/site-packages/pymomentum/geometry.cpython-312-x86_64-linux-gnu.so: undefined symbol: _ZTVN4axel3BvhIdLm4EEE ``` This was not caught by any of the CI, which is odd but could happen with different compiler settings. Reviewed By: cdtwigg Differential Revision: D85474531
jeongseok-meta
force-pushed
the
export-D85474531
branch
from
4ef804a to
e274566
Compare
Summary: Pull Request resolved: #727 Fix linking error when importing geometry from pymomentum PyPI package: ``` Python 3.12.11 (main, Sep 2 2025, 14:20:58) [Clang 20.1.4 ] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import pymomentum.geometry Traceback (most recent call last): File "<stdin>", line 1, in <module> ImportError: /home/jeongseok/dev/tmp/.venv/lib/python3.12/site-packages/pymomentum/geometry.cpython-312-x86_64-linux-gnu.so: undefined symbol: _ZTVN4axel3BvhIdLm4EEE ``` This was not caught by any of the CI, which is odd but could happen with different compiler settings. Reviewed By: cdtwigg Differential Revision: D85474531
jeongseok-meta
force-pushed
the
export-D85474531
branch
from
e274566 to
2da7c65
Compare
jeongseok-meta
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
jeongseok-meta
temporarily deployed
to
pypi-cpu
GitHub Actions
Inactive
jeongseok-meta
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
jeongseok-meta
temporarily deployed
to
pypi-gpu
GitHub Actions
Inactive
|
This pull request has been merged in 6d39339. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix linking error when importing geometry from pymomentum PyPI package:
This was not caught by any of the CI, which is odd but could happen with different compiler settings.
Differential Revision: D85474531