Implemented Auth::UseUserAccessGroup for iOS and stubbed for other pl… #1753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atforms. This method allows specifying a Keychain Access Group for sharing user authentication data across multiple apps on iOS. It is a no-op on Android and desktop platforms.
jonsimantov
commented
Jun 27, 2025
| #if FIREBASE_PLATFORM_IOS | ||
| return UseUserAccessGroupInternal(auth_data_, access_group); | ||
| #else | ||
| return kAuthErrorUnimplemented; |
There was a problem hiding this comment.
Let's just return kAuthErrorNone.
jonsimantov
commented
Jun 27, 2025
| @@ -632,6 +632,10 @@ void DestroyUserDataPersist(AuthData* auth_data) { | |||
| auth_data->auth->RemoveAuthStateListener(auth_impl->user_data_persist.get()); | |||
| } | |||
|
|
|||
| AuthError Auth::UseUserAccessGroup(const char* access_group) { | |||
| return kAuthErrorUnimplemented; | |||
jonsimantov
commented
Jun 27, 2025
| @@ -497,6 +497,17 @@ class Auth { | |||
| /// emulator. | |||
| /// | |||
| void UseEmulator(std::string host, uint32_t port); | |||
|
|
|||
There was a problem hiding this comment.
Move this out of the ifndef SWIG section
jonsimantov
commented
Jun 27, 2025
| @@ -137,6 +137,9 @@ void SignInCallback(FIRUser *_Nullable user, NSError *_Nullable error, | |||
| /// like user interaction errors, they are actually caused by bad provider ids. | |||
| NSError *RemapBadProviderIDErrors(NSError *_Nonnull error); | |||
|
|
|||
| // iOS-specific implementation of Auth::UseUserAccessGroup. | |||
| AuthError UseUserAccessGroupInternal(AuthData* auth_data, const char* access_group); | |||
There was a problem hiding this comment.
This is simple enough not to need an Internal-based implementation, let's just implement it in the regular UseUserAccessGroup function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atforms.
This method allows specifying a Keychain Access Group for sharing user authentication data across multiple apps on iOS. It is a no-op on Android and desktop platforms.
Description
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.