-
Notifications
You must be signed in to change notification settings - Fork 125
Implemented Auth::UseUserAccessGroup for iOS and stubbed for other pl… #1753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -632,6 +632,10 @@ void DestroyUserDataPersist(AuthData* auth_data) { | |
auth_data->auth->RemoveAuthStateListener(auth_impl->user_data_persist.get()); | ||
} | ||
|
||
AuthError Auth::UseUserAccessGroup(const char* access_group) { | ||
return kAuthErrorUnimplemented; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. kAuthErrorNone |
||
} | ||
|
||
void LoadFinishTriggerListeners(AuthData* auth_data) { | ||
MutexLock destructing_lock(auth_data->destructing_mutex); | ||
if (auth_data->destructing) { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -497,6 +497,17 @@ class Auth { | |
/// emulator. | ||
/// | ||
void UseEmulator(std::string host, uint32_t port); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move this out of the ifndef SWIG section |
||
/// @brief Sets the user access group to use for data sharing. | ||
/// | ||
/// This method is only functional on iOS. On other platforms, it will | ||
/// immediately return kAuthErrorUnimplemented. | ||
/// | ||
/// @param[in] access_group The access group to use. | ||
/// | ||
/// @return kAuthErrorNone on success, or an AuthError code if an error | ||
/// occurred. | ||
AuthError UseUserAccessGroup(const char* access_group); | ||
#endif //! defined(DOXYGEN), to hide the api from public documentation. | ||
|
||
/// Gets the App this auth object is connected to. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,6 +137,9 @@ void SignInCallback(FIRUser *_Nullable user, NSError *_Nullable error, | |
/// like user interaction errors, they are actually caused by bad provider ids. | ||
NSError *RemapBadProviderIDErrors(NSError *_Nonnull error); | ||
|
||
// iOS-specific implementation of Auth::UseUserAccessGroup. | ||
AuthError UseUserAccessGroupInternal(AuthData* auth_data, const char* access_group); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is simple enough not to need an Internal-based implementation, let's just implement it in the regular UseUserAccessGroup function. |
||
|
||
} // namespace auth | ||
} // namespace firebase | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just return kAuthErrorNone.