Skip to content

chore(analytics): Remove cSettings from Package.swift #17567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025

Conversation

koji-1009
Copy link
Contributor

@koji-1009 koji-1009 commented Jul 27, 2025

Description

This PR removes unnecessary cSettings from the Package.swift file for the firebase_analytics package.

https://developer.apple.com/documentation/packagedescription/csetting
https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors

ref #17403

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@koji-1009 koji-1009 marked this pull request as ready for review July 27, 2025 12:41
@koji-1009 koji-1009 force-pushed the chore/remove_csettings_analytics branch from d55a0d2 to 5e09048 Compare July 29, 2025 04:59
@SelaseKay
Copy link
Contributor

LGTM!

@SelaseKay SelaseKay merged commit e7af1b0 into firebase:main Jul 30, 2025
31 of 38 checks passed
@koji-1009 koji-1009 deleted the chore/remove_csettings_analytics branch July 30, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants