Fixed Firefox icon and moved viewBox from icon props to SVG element

[marko-lisica]

Related issue: Resolves #31845

Checklist for submitter

• QA'd all new/changed functionality manually

[codecov]

Codecov Report

❌ Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.23%. Comparing base (8973500) to head (6acda0e).

Files with missing lines	Patch %	Lines
...ftwarePage/components/icons/AdobeCreativeCloud.tsx	0.00%	1 Missing ⚠️
...pages/SoftwarePage/components/icons/AndroidApp.tsx	0.00%	1 Missing ⚠️
...es/SoftwarePage/components/icons/BeyondCompare.tsx	0.00%	1 Missing ⚠️
...end/pages/SoftwarePage/components/icons/Falcon.tsx	0.00%	1 Missing ⚠️
...tend/pages/SoftwarePage/components/icons/ITerm.tsx	0.00%	1 Missing ⚠️
...warePage/components/icons/OmnissaHorizonClient.tsx	0.00%	1 Missing ⚠️
...ontend/pages/SoftwarePage/components/icons/P4V.tsx	0.00%	1 Missing ⚠️
.../pages/SoftwarePage/components/icons/VncViewer.tsx	0.00%	1 Missing ⚠️
...pages/SoftwarePage/components/icons/WindowsApp.tsx	0.00%	1 Missing ⚠️
...s/SoftwarePage/components/icons/YubikeyManager.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #34076    +/-   ##
========================================
  Coverage   64.23%   64.23%            
========================================
  Files        2058     2057     -1     
  Lines      206902   206744   -158     
  Branches     6899     6767   -132     
========================================
- Hits       132900   132805    -95     
+ Misses      63576    63525    -51     
+ Partials    10426    10414    -12     

Flag	Coverage Δ
frontend	53.67% <54.54%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[marko-lisica]

@RachelElysia After initially implementing the Firefox icon, the colors were wrong, so I fixed them. Now I realized that not all icons can have viewBox="0 0 32 32" which was set as a prop for each icon. The Firefox icon is made that way so it works properly if viewBox="0 0 512 512". I think viewBox should be defined for each icon.