Skip to content

Fixed Firefox icon and moved viewBox from icon props to SVG element #34076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fixed Firefox icon and moved viewBox from icon props to SVG element #34076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c029ce
fixed firefox icon and moved viewBox from icon props to svg element
marko-lisica Oct 9, 2025
e2e0010
Merge branch 'main' into 31845-fix-firefox-icon
marko-lisica Oct 9, 2025
b74694c
reverted viewBox back to icon component and added g element with tran…
marko-lisica Oct 10, 2025
9c1ee90
Merge branch '31845-fix-firefox-icon' of https://github.com/fleetdm/f…
marko-lisica Oct 10, 2025
6acda0e
Merge branch 'main' into 31845-fix-firefox-icon
marko-lisica Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/pages/SoftwarePage/components/icons/AdobeCreativeCloud.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as React from "react";
import type { SVGProps } from "react";

const AdobeCreativeCloud = (props: SVGProps<SVGSVGElement>) => (
<svg xmlns="http://www.w3.org/2000/svg" width={32} height={32} {...props}>
<svg xmlns="http://www.w3.org/2000/svg" {...props}>
<image
width={32}
height={32}
Expand Down
7 changes: 1 addition & 6 deletions frontend/pages/SoftwarePage/components/icons/AndroidApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,7 @@ import React from "react";
import type { SVGProps } from "react";

const AndroidApp = (props: SVGProps<SVGSVGElement>) => (
<svg
fill="none"
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 32 32"
{...props}
>
<svg fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
<rect width="32" height="32" rx="4" fill="#515774" />
<path
d="M22.5479 9.35083C22.6927 9.36356 22.8329 9.40859 22.958 9.48267C23.1353 9.58752 23.2749 9.74676 23.3545 9.93677C23.4126 10.0745 23.4372 10.2241 23.4277 10.3733C23.4183 10.5225 23.3748 10.6678 23.2998 10.7971C23.1517 11.0535 23.0026 11.3103 22.8535 11.5667L22.2324 12.6389C22.0205 13.005 21.8075 13.3706 21.5957 13.7366C21.5917 13.7432 21.5889 13.7506 21.585 13.7571C22.2592 14.1778 22.8838 14.6732 23.4473 15.2336C24.2193 16.0005 24.8683 16.8829 25.3711 17.8479C25.8846 18.8327 26.2393 19.8928 26.4209 20.9885C26.428 21.0309 26.4345 21.0736 26.4414 21.1165L26.4395 21.1174C26.4628 21.2704 26.4832 21.4243 26.5 21.5793H5.5C5.51669 21.4249 5.53686 21.2709 5.56055 21.1174C5.5671 21.075 5.57393 21.0319 5.58105 20.9895C5.62469 20.7272 5.67821 20.4665 5.74121 20.2083C5.942 19.389 6.24088 18.5968 6.63086 17.8489C6.85674 17.4148 7.11222 16.9962 7.39648 16.5979C7.91793 15.8671 8.53011 15.2053 9.21777 14.6282C9.60222 14.3057 10.0093 14.0111 10.4355 13.7463C10.434 13.7434 10.4313 13.7406 10.4297 13.7375C10.2179 13.3716 10.0057 13.0059 9.79395 12.6399C9.58679 12.2827 9.38033 11.9249 9.17285 11.5676C9.02448 11.3108 8.87564 11.0536 8.72656 10.7971C8.69151 10.7365 8.66378 10.6739 8.64258 10.6096C8.57209 10.3895 8.58218 10.1508 8.67188 9.93774C8.6891 9.89624 8.71035 9.85553 8.7334 9.81665C8.81536 9.67961 8.93009 9.56518 9.06738 9.48364C9.19254 9.40897 9.3333 9.36317 9.47852 9.35083C9.66098 9.33484 9.84433 9.37179 10.0068 9.4563C10.1693 9.54081 10.3048 9.66984 10.3965 9.82837C10.5446 10.0847 10.6928 10.3417 10.8418 10.5979L11.4639 11.6702C11.6756 12.0361 11.8878 12.4018 12.0996 12.7678C12.1208 12.8052 12.1435 12.8428 12.165 12.8801C12.2849 12.8329 12.4057 12.7878 12.5273 12.7454C13.5831 12.3779 14.7149 12.1731 15.8926 12.1614C15.929 12.1609 15.9648 12.1604 16.001 12.1604C17.3255 12.1604 18.5927 12.4045 19.7607 12.8499C19.7929 12.8621 19.8253 12.8751 19.8574 12.8879C19.8804 12.8475 19.9037 12.8077 19.9268 12.7678C20.1385 12.4019 20.3507 12.0361 20.5625 11.6702L21.1846 10.5979C21.333 10.3415 21.4811 10.0839 21.6299 9.82739C21.7062 9.69563 21.8136 9.58388 21.9414 9.50122C22.0692 9.41871 22.2149 9.36725 22.3662 9.35181C22.4266 9.34571 22.4874 9.3457 22.5479 9.35083ZM11.8047 16.7991C11.3845 16.5194 10.765 16.7134 10.4199 17.2317C10.0752 17.7503 10.1358 18.3972 10.5557 18.677C10.9758 18.9567 11.5966 18.763 11.9414 18.2444C12.2861 17.7259 12.2247 17.0787 11.8047 16.7991ZM21.5986 17.2297C21.2539 16.7113 20.6338 16.5177 20.2139 16.7971C19.7937 17.0768 19.7321 17.7249 20.0771 18.2434C20.422 18.7619 21.043 18.9547 21.4629 18.675C21.8827 18.3952 21.9435 17.748 21.5986 17.2297Z"
Expand Down
2 changes: 1 addition & 1 deletion frontend/pages/SoftwarePage/components/icons/BeyondCompare.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as React from "react";
import type { SVGProps } from "react";

const BeyondCompare = (props: SVGProps<SVGSVGElement>) => (
<svg xmlns="http://www.w3.org/2000/svg" width={32} height={32} {...props}>
<svg xmlns="http://www.w3.org/2000/svg" {...props}>
<image
width={32}
height={32}
Expand Down
9 changes: 1 addition & 8 deletions frontend/pages/SoftwarePage/components/icons/Falcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,7 @@ import React from "react";
import type { SVGProps } from "react";

const Falcon = (props: SVGProps<SVGSVGElement>) => (
<svg
width="32"
height="32"
viewBox="0 0 32 32"
fill="none"
xmlns="http://www.w3.org/2000/svg"
{...props}
>
<svg fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
<rect width="32" height="32" fill="#D31C12" />
<path
fillRule="evenodd"
Expand Down
331 changes: 144 additions & 187 deletions frontend/pages/SoftwarePage/components/icons/Firefox.tsx
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion frontend/pages/SoftwarePage/components/icons/ITerm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as React from "react";
import type { SVGProps } from "react";

const ITerm = (props: SVGProps<SVGSVGElement>) => (
<svg xmlns="http://www.w3.org/2000/svg" width={32} height={32} {...props}>
<svg xmlns="http://www.w3.org/2000/svg" {...props}>
<image
width={32}
height={32}
Expand Down
2 changes: 1 addition & 1 deletion frontend/pages/SoftwarePage/components/icons/OmnissaHorizonClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as React from "react";
import type { SVGProps } from "react";

const OmnissaHorizonClient = (props: SVGProps<SVGSVGElement>) => (
<svg xmlns="http://www.w3.org/2000/svg" width={32} height={32} {...props}>
<svg xmlns="http://www.w3.org/2000/svg" {...props}>
<image
width={32}
height={32}
Expand Down
2 changes: 1 addition & 1 deletion frontend/pages/SoftwarePage/components/icons/P4V.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as React from "react";
import type { SVGProps } from "react";

const P4V = (props: SVGProps<SVGSVGElement>) => (
<svg xmlns="http://www.w3.org/2000/svg" width={32} height={32} {...props}>
<svg xmlns="http://www.w3.org/2000/svg" {...props}>
<image
width={32}
height={32}
Expand Down
2 changes: 1 addition & 1 deletion frontend/pages/SoftwarePage/components/icons/VncViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as React from "react";
import type { SVGProps } from "react";

const VncViewer = (props: SVGProps<SVGSVGElement>) => (
<svg xmlns="http://www.w3.org/2000/svg" width={32} height={32} {...props}>
<svg xmlns="http://www.w3.org/2000/svg" {...props}>
<image
width={32}
height={32}
Expand Down
2 changes: 1 addition & 1 deletion frontend/pages/SoftwarePage/components/icons/WindowsApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React from "react";
import type { SVGProps } from "react";

const WindowsApp = (props: SVGProps<SVGSVGElement>) => (
<svg fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
<svg xmlns="http://www.w3.org/2000/svg" fill="none" {...props}>
<path fill="#F9FAFC" d="M0 0h32v32H0z" />
<path
fillRule="evenodd"
Expand Down
2 changes: 1 addition & 1 deletion frontend/pages/SoftwarePage/components/icons/YubikeyManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as React from "react";
import type { SVGProps } from "react";

const YubiKeyManager = (props: SVGProps<SVGSVGElement>) => (
<svg xmlns="http://www.w3.org/2000/svg" width={32} height={32} {...props}>
<svg xmlns="http://www.w3.org/2000/svg" {...props}>
<image
width={32}
height={32}
Expand Down
Loading