Treat missing dependencies as no dependencies#4321
Open
Desarc wants to merge 1 commit intofsprojects:masterfrom
Open
Treat missing dependencies as no dependencies#4321Desarc wants to merge 1 commit intofsprojects:masterfrom
Desarc wants to merge 1 commit intofsprojects:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #4319.
I'm not sure how I would add a test for this, or if it can cause issues in other contexts. I have tested with both of the versions of JFrog Artifactory we are using, and a few different packages, and there were no issues. I also tested with https://api.nuget.org/v3/index.json, same result.
Please let me know if there are other cases that should be tested, if I need to add something to the test suite, or if there are other things to consider with this change.