Skip to content

Treat missing dependencies as no dependencies #4321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Desarc wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −5
Open

Treat missing dependencies as no dependencies #4321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/Paket.Core/Dependencies/NuGetV2.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ let private followODataLink auth url =
let mutable uri = null // warn once per specific API endpoint, but try to cut the query
let baseUrl = if Uri.TryCreate(url, UriKind.Absolute, &uri) then uri.AbsolutePath else url
traceWarnIfNotBefore baseUrl
"At least one 'next' link (index %d) returned a empty result (noticed on '%O'): ['%s']"
"At least one 'next' link (index %d) returned a empty result (noticed on '%O'): ['%s']"
i url (System.String.Join("' ; '", linksToFollow))
| None -> ()
return
Expand Down Expand Up @@ -179,10 +179,11 @@ let private handleODataEntry nugetURL packageName version entry =
| Some node -> node.InnerText
| _ -> ""

// If a package has no dependencies, JFrog Artifactory will return an XML structure without the Dependencies node.
let dependencies =
match entry |> getNode "properties" |> optGetNode "Dependencies" with
| Some node -> node.InnerText
| None -> failwithf "unable to find dependencies for package %O %O" packageName version
| None -> ""

let rawPackages =
let split (d : string) =
Expand All @@ -195,7 +196,7 @@ let private handleODataEntry nugetURL packageName version entry =
| Some p ->
Some p
| None ->
if not (restriction.StartsWith "_") then
if not (restriction.StartsWith "_") then
Logging.traceWarnIfNotBefore ("Package", restriction, packageName, version) "Could not detect any platforms from '%s' in package %O %O, please tell the package authors" restriction packageName version
None
else Some PlatformMatching.ParsedPlatformPath.Empty)
Expand Down Expand Up @@ -480,5 +481,3 @@ let FindPackages(auth, nugetURL, packageNamePrefix, maxResults) =
with e ->
return FSharp.Core.Result.Error (ExceptionDispatchInfo.Capture e)
}