-
Notifications
You must be signed in to change notification settings - Fork 0
Update okhttp monorepo to v5 (major) - reopen #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec5d2c1
to
96fc424
Compare
96fc424
to
498aece
Compare
01c570b
to
61d79af
Compare
Job Summary for GradleCheck PR :: kotlin-tests
|
006611a
to
4384837
Compare
Job Summary for GradleCheck PR :: kotlin-tests
|
Job Summary for GradleCheck PR :: kotlin-tests
|
4384837
to
bf28b37
Compare
Job Summary for GradleCheck PR :: kotlin-tests
|
bf28b37
to
bcda350
Compare
Job Summary for GradleCheck PR :: kotlin-tests
|
bcda350
to
b7d9337
Compare
Job Summary for GradleCheck PR :: kotlin-tests
|
b7d9337
to
ae471d0
Compare
Job Summary for GradleCheck PR :: kotlin-tests
|
ae471d0
to
543ef09
Compare
Job Summary for GradleCheck PR :: kotlin-tests
|
543ef09
to
6373d04
Compare
Job Summary for GradleCheck PR :: kotlin-tests
|
6373d04
to
d3fe344
Compare
Job Summary for GradleCheck PR :: kotlin-tests
|
Job Summary for GradleCheck PR :: kotlin-tests
|
Kotlin/kotlin-jupyter#484 explains the root cause of this failure. |
Merged
gabrielfeo
added a commit
that referenced
this pull request
Jul 31, 2025
Bump okhttp to 5.1.0 and re-order dependency declarations so that the Kotlin kernel for Jupyter will use the higher version of `okio`, `3.15.0`, which is requested and required by `okhttp:5.1.0`, avoiding a runtime failure. The change in the buildscript is reflected in the library's published `.pom` file. It appears that the kernel will pick the first seen version of an artifact when traversing the dependencies and does not consider dependency constraints. `okhttp` must be declared first in the pom file and `moshi`, which depends on an older version of `okio`, must be declared later. This bump without re-ordering dependencies would result in a failure as described in [Kotlin/kotlin-jupyter#484][issue] and seen in this [build scan][failing-build] from #425. [issue]: Kotlin/kotlin-jupyter#484 [failing-build]: https://scans.gradle.com/s/3mvhfatr7gduy/tests/task/:library:examplesTest/details/com.gabrielfeo.develocity.api.example.notebook.NotebooksTest/testMostFrequentBuildsNotebook()?focused-execution=1&page=eyJvdXRwdXQiOnsiMCI6NH19&top-execution=1#L795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.12.0
->5.1.0
4.12.0
->5.1.0
4.12.0
->5.1.0
Release Notes
square/okhttp (com.squareup.okhttp3:mockwebserver)
v5.1.0
2025-07-07
New:
Response.peekTrailers()
. When we changedResponse.trailers()
to block instead ofthrowing in 5.0.0, we inadvertently removed the ability for callers to peek the trailers
(by catching the
IllegalStateException
if they weren't available). This new API restores thatcapability.
Fix: Don't crash on
trailers()
if the response doesn't have a body. We broke [Retrofit] userswho read the trailers on the
raw()
OkHttp response, after its body was decoded.v5.0.0
2025-07-02
This is our first stable release of OkHttp since 2023. Here's the highlights if you're upgrading
from OkHttp 4.x:
OkHttp is now packaged as separate JVM and Android artifacts. This allows us to offer
platform-specific features and optimizations. If your build system handles [Gradle module metadata],
this change should be automatic.
MockWebServer has a new coordinate and package name. We didn’t like that our old artifact
depends on JUnit 4 so the new one doesn’t. It also has a better API built on immutable values. (We
intend to continue publishing the old
okhttp3.mockwebserver
artifact so there’s no urgency tomigrate.)
OkHttp now supports Happy Eyeballs ([RFC 8305][rfc_8305]) for IPv4+IPv6 networks. It attempts
both IPv6 and IPv4 connections concurrently, keeping whichever connects first.
We’ve improved our Kotlin APIs. You can skip the builder:
OkHttp now supports [GraalVM].
Here’s what has changed since 5.0.0-alpha.17:
NoSuchMethodError
when using OkHttp with the Sentry SDK.okhttp3.mockwebserver.RecordedRequest.path
property. Weinadvertently changed this behavior when we introduced the
mockwebserver3
API.This PR was generated by Mend Renovate. View the repository job log.