feat(size-analysis): Add upload functionality for size analysis #915

runningcode · 2025-06-12T14:22:11Z

📜 Description

This adds a new task SentryUploadAppArtifactTask which calls to
sentry-cli mobile-app upload (apk or abb).

Most sentry functionality is enabled by the variant filter in the sentry extension. However, the size upload functionality is enabled by default when we are on CI.
This is because some teams might want to enable debug builds to upload or have some different logic than the regular variant filter.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

I reviewed the submitted code
I added tests to verify the changes
I updated the docs if needed
No breaking changes

🔮 Next steps

gradle/libs.versions.toml

plugin-build/src/main/kotlin/io/sentry/android/gradle/AndroidComponentsConfig.kt

runningcode · 2025-06-12T14:45:01Z

plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadAppArtifactTask.kt

+    if (bundleFile != null) {
+      if (bundleFile.exists()) {
+        args.add(bundleFile.path)
+        return


actually, if we need to add more arguments to the upload (like proguard or other files), this is perhaps not the best design since it relies on early returns.

Yeah I think we might need to add mappings for apks, so I think a when statement would be better here, like when AAB, args are just aab, when APK we could append proguard mappings (in future when added to CLI), etc.

plugin-build/src/agp74/kotlin/io/sentry/android/gradle/AGP74Compat.kt

runningcode · 2025-06-16T16:02:34Z

plugin-build/src/main/kotlin/io/sentry/android/gradle/extensions/SizeAnalysisExtension.kt

+  val enabled: Property<Boolean> =
+    objects
+      .property(Boolean::class.java)
+      .convention(providerFactory.isCi() && false) // set to false for now otherwise upload fails CI


This is hardcoded to false for the time being so that we don’t auto-upload while it isn’t working.

romtsn · 2025-06-25T09:19:11Z

CHANGELOG.md

@@ -2,6 +2,10 @@

 ## Unreleased

+### Features
+
+- Add upload functionality for size analysis ([#915](https://github.com/getsentry/sentry-android-gradle-plugin/pull/915))


I guess we'd need to expand on this, like mention the new sizeAnalysis extension and when the builds are uploaded by default, but this can be done later when we GA this

romtsn · 2025-06-25T09:23:44Z

plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadAppArtifactTask.kt

+
+  @get:InputFile
+  @get:Optional
+  @get:PathSensitive(PathSensitivity.NAME_ONLY)


should this be RELATIVE? In case e.g. the variant changes (e.g. build/outputs/${variant}/aab)? Same for the apk

If the variant changes then the content of the file will change as well. I don't see why the location of file is important here though. It won't affect the directory in the uploaded zip.

romtsn · 2025-06-25T09:26:14Z

plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadAppArtifactTask.kt

+    ): Pair<TaskProvider<SentryUploadAppArtifactTask>, TaskProvider<SentryUploadAppArtifactTask>> {
+      val uploadMobileBundleTask =
+        project.tasks.register(
+          "uploadSentryBundle$taskSuffix",


Suggested change

"uploadSentryBundle$taskSuffix",

"uploadSentryBundle${taskSuffix}ForSizeAnalysis",

don't know if we have to be specific here, but just a suggestion

This is a good point, but we might do more than just size analysis with the upload.

romtsn · 2025-06-25T09:28:14Z

plugin-build/src/test/kotlin/io/sentry/android/gradle/tasks/SentryUploadAppArtifactTaskTest.kt

Would be cool to add an integration test - you can take a look at https://github.com/getsentry/sentry-android-gradle-plugin/blob/main/plugin-build/src/test/kotlin/io/sentry/android/gradle/integration/SentryPluginIntegrationTest.kt which tests uploads against a simple python server spawned locally

i've added this! good suggestion!

romtsn

minor things, but nothing blocking. LGTM, great stuff!

# Conflicts: # examples/android-guardsquare-proguard/sentry.properties # plugin-build/sentry-cli.properties

github-actions · 2025-08-28T12:27:45Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ed2fa6d

runningcode · 2025-08-28T14:07:31Z

plugin-build/sentry-cli.properties

@@ -1,2 +1,2 @@
-version = 2.52.0
+version = 2.53.0-alpha


This is so that the integration tests use 2.53.0-alpha and pass.

runningcode force-pushed the no/size-analysis branch 3 times, most recently from 6e01215 to 00bd9a2 Compare June 12, 2025 14:42

runningcode commented Jun 12, 2025

View reviewed changes

plugin-build/src/agp74/kotlin/io/sentry/android/gradle/AGP74Compat.kt Outdated Show resolved Hide resolved

runningcode force-pushed the no/size-analysis branch 6 times, most recently from 661868d to c6f323b Compare June 16, 2025 15:39

runningcode commented Jun 16, 2025

View reviewed changes

runningcode marked this pull request as ready for review June 16, 2025 16:42

runningcode requested review from markushi, romtsn, adinauer, stefanosiano, lcian, chromy and rbro112 as code owners June 16, 2025 16:42

runningcode force-pushed the no/size-analysis branch from c6f323b to 9f85630 Compare June 18, 2025 12:19

romtsn reviewed Jun 25, 2025

View reviewed changes

romtsn approved these changes Jun 25, 2025

View reviewed changes

runningcode added 4 commits August 26, 2025 10:55

New sentry command

c4e821d

# Conflicts: # examples/android-guardsquare-proguard/sentry.properties # plugin-build/sentry-cli.properties

not working

de836ff

adding tests

ad8e426

Size analysis working

4972ae8

runningcode added 5 commits August 26, 2025 10:55

Add extension

84db724

working on test

820ccd6

remove shadow

bf5c56e

Add tests and CI check

bc04681

Disable uploading by default

a7a245b

runningcode force-pushed the no/size-analysis branch from 9f85630 to a7a245b Compare August 26, 2025 10:12

runningcode added 2 commits August 26, 2025 12:13

Remove second truth

5f93a34

Use build instead of mobile-app command

44a8525

runningcode force-pushed the no/size-analysis branch from e653a47 to 44a8525 Compare August 28, 2025 07:55

runningcode changed the title ~~Add upload functionality for size analysis~~ feat() Add upload functionality for size analysis Aug 28, 2025

runningcode changed the title ~~feat() Add upload functionality for size analysis~~ feat(size-analysis) Add upload functionality for size analysis Aug 28, 2025

runningcode changed the title ~~feat(size-analysis) Add upload functionality for size analysis~~ feat(size-analysis): Add upload functionality for size analysis Aug 28, 2025

Add SentryPluginIntegrationTest

03b3c23

runningcode force-pushed the no/size-analysis branch from 31744bb to 03b3c23 Compare August 28, 2025 12:29

Use alpha version

b9751ad

runningcode force-pushed the no/size-analysis branch from 51c8e48 to b9751ad Compare August 28, 2025 12:56

Improve python server functionality.

ed2fa6d

runningcode force-pushed the no/size-analysis branch from d2f0f7f to ed2fa6d Compare August 28, 2025 13:59

runningcode commented Aug 28, 2025

View reviewed changes

runningcode requested a review from romtsn August 28, 2025 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(size-analysis): Add upload functionality for size analysis #915

feat(size-analysis): Add upload functionality for size analysis #915

Uh oh!

runningcode commented Jun 12, 2025

Uh oh!

Uh oh!

Uh oh!

runningcode Jun 12, 2025

Uh oh!

rbro112 Jun 17, 2025

Uh oh!

Uh oh!

runningcode Jun 16, 2025

Uh oh!

romtsn Jun 25, 2025

Uh oh!

romtsn Jun 25, 2025

Uh oh!

runningcode Aug 26, 2025

Uh oh!

romtsn Jun 25, 2025 •

edited

Loading

Uh oh!

runningcode Aug 26, 2025

Uh oh!

romtsn Jun 25, 2025

Uh oh!

runningcode Aug 28, 2025

Uh oh!

romtsn left a comment

Uh oh!

github-actions bot commented Aug 28, 2025 •

edited

Loading

Uh oh!

runningcode Aug 28, 2025

Uh oh!

Uh oh!

	"uploadSentryBundle$taskSuffix",
	"uploadSentryBundle${taskSuffix}ForSizeAnalysis",

Uh oh!

feat(size-analysis): Add upload functionality for size analysis #915

Are you sure you want to change the base?

feat(size-analysis): Add upload functionality for size analysis #915

Uh oh!

Conversation

runningcode commented Jun 12, 2025

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

romtsn Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

romtsn left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romtsn Jun 25, 2025 •

edited

Loading

github-actions bot commented Aug 28, 2025 •

edited

Loading