Run test pipeline once #1072
Merged
Run test pipeline once #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1072 +/- ##
==========================================
+ Coverage 86.79% 86.82% +0.02%
==========================================
Files 55 56 +1
Lines 5962 5964 +2
==========================================
+ Hits 5175 5178 +3
Misses 643 643
+ Partials 144 143 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cleptric
reviewed
Aug 14, 2025
.github/workflows/test.yml
Outdated
| # pull requests, only run this step for a single job in the matrix. For | ||
| # all other workflow triggers (e.g., pushes to a release branch) run | ||
| # this step for the whole matrix. | ||
| RUN_RACE_TESTS: ${{ github.event_name != 'pull_request' || (matrix.go == '1.23' && matrix.os == 'ubuntu') }} |
There was a problem hiding this comment.
Suggested change
| RUN_RACE_TESTS: ${{ github.event_name != 'pull_request' || (matrix.go == '1.23' && matrix.os == 'ubuntu') }} | |
| RUN_RACE_TESTS: ${{ github.event_name != 'pull_request' || (matrix.go == '1.24' && matrix.os == 'ubuntu') }} |
cleptric
reviewed
Aug 14, 2025
.github/workflows/test.yml
Outdated
| timeout-minutes: 15 | ||
| strategy: | ||
| matrix: | ||
| go: ["1.24", "1.23", "1.22"] | ||
| os: [ubuntu, windows, macos] | ||
| fail-fast: false | ||
| fail-fast: false |
cleptric
reviewed
Aug 14, 2025
Comment on lines
-47
to
-48
| - name: Check go.mod Tidiness | ||
| run: make mod-tidy |
There was a problem hiding this comment.
The step was running only on go1.21 (so not at all). I suppose it was setup like this to save CI time?
There was a problem hiding this comment.
No, this is required to make sure that our lowest supported Go version actually works 😅
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cleptric
approved these changes
Aug 14, 2025
giortzisg
added a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1070.
When the pipeline was running the tests with the
-racecheck, also the normal tests were run. This PR refactors the pipeline to:-raceand-coverageflags on all os matrixes (except for PRs).Also bumping the min supported go version to 1.22. It was supposed to be bumped with the previous CI update.