-
Notifications
You must be signed in to change notification settings - Fork 241
Run test pipeline once #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Run test pipeline once #1072
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d1c15b9
fix pipeline to run tests once
giortzisg d42f14b
remove test branch
giortzisg c115af5
add tidy step
giortzisg 74561a0
add tidy for min version
giortzisg 15ed4d8
upload coverage only once
giortzisg c7874fe
bump to go1.22
giortzisg bbf383b
cover for every version
giortzisg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,11 @@ jobs: | |
| env: | ||
| GO111MODULE: "on" | ||
| GOFLAGS: "-mod=readonly" | ||
| # The race detector adds considerable runtime overhead. To save time on | ||
| # pull requests, only run this step for a single job in the matrix. For | ||
| # all other workflow triggers (e.g., pushes to a release branch) run | ||
| # this step for the whole matrix. | ||
| RUN_RACE_TESTS: ${{ github.event_name != 'pull_request' || (matrix.go == '1.24' && matrix.os == 'ubuntu') }} | ||
| steps: | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
|
|
@@ -40,27 +45,20 @@ jobs: | |
| key: ${{ runner.os }}-go-${{ matrix.go }}-${{ hashFiles('**/go.sum') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-go-${{ matrix.go }}- | ||
| - name: Tidy for min version | ||
| run: make mod-tidy | ||
| if: ${{ matrix.go == '1.22' }} | ||
| - name: Build | ||
| run: make build | ||
| - name: Vet | ||
| run: make vet | ||
| - name: Check go.mod Tidiness | ||
| run: make mod-tidy | ||
| if: ${{ matrix.go == '1.21' }} | ||
| - name: Test | ||
| run: make test-coverage | ||
| - name: Test${{ env.RUN_RACE_TESTS == 'true' && ' (with race detection)' || '' }} | ||
| run: ${{ env.RUN_RACE_TESTS == 'true' && 'make test-race-coverage' || 'make test-coverage' }} | ||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # [email protected] | ||
| with: | ||
| directory: .coverage | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| - name: Test (with race detection) | ||
| run: make test-race | ||
| # The race detector adds considerable runtime overhead. To save time on | ||
| # pull requests, only run this step for a single job in the matrix. For | ||
| # all other workflow triggers (e.g., pushes to a release branch) run | ||
| # this step for the whole matrix. | ||
| if: ${{ github.event_name != 'pull_request' || (matrix.go == '1.23' && matrix.os == 'ubuntu') }} | ||
| timeout-minutes: 15 | ||
| strategy: | ||
| matrix: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/getsentry/sentry-go/echo | ||
|
|
||
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| replace github.com/getsentry/sentry-go => ../ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/getsentry/sentry-go/fasthttp | ||
|
|
||
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| replace github.com/getsentry/sentry-go => ../ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/getsentry/sentry-go/fiber | ||
|
|
||
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| replace github.com/getsentry/sentry-go => ../ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/getsentry/sentry-go/gin | ||
|
|
||
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| replace github.com/getsentry/sentry-go => ../ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/getsentry/sentry-go | ||
|
|
||
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| require ( | ||
| github.com/go-errors/errors v1.4.2 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/getsentry/sentry-go/iris | ||
|
|
||
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| replace github.com/getsentry/sentry-go => ../ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/getsentry/sentry-go/logrus | ||
|
|
||
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| replace github.com/getsentry/sentry-go => ../ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/getsentry/sentry-go/negroni | ||
|
|
||
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| replace github.com/getsentry/sentry-go => ../ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/getsentry/sentry-go/otel | ||
|
|
||
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| replace github.com/getsentry/sentry-go => ../ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/getsentry/sentry-go/slog | ||
|
|
||
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| replace github.com/getsentry/sentry-go => ../ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/getsentry/sentry-go/zerolog | ||
|
|
||
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| replace github.com/getsentry/sentry-go => ../ | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The step was running only on go1.21 (so not at all). I suppose it was setup like this to save CI time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is required to make sure that our lowest supported Go version actually works 😅