Skip to content

fix(dynamic-sampling): display minimum sample rate rules correctly in admin #95868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

fix(dynamic-sampling): display minimum sample rate rules correctly in admin #95868

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64df723
fix(dynamic-sampling): display minimum sample rate rules correctly in…
shellmayr Jul 18, 2025
f4463e6
add naming correctly as well
shellmayr Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion static/gsAdmin/views/dynamicSamplingPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,10 @@ function DynamicSamplingRulesTable({
const round = (value: number) => Math.round(value * 10000) / 10000;

const formatSamplingRateValue = (samplingValue: any) => {
if (samplingValue.type === 'sampleRate') {
if (
samplingValue.type === 'sampleRate' ||
samplingValue.type === 'minimumSampleRate'
) {
return `${round(samplingValue.value * 100)}%`;
}
if (samplingValue.type === 'reservoir') {
Expand Down
Loading