feat(aci): UI to filter monitors by assignee

[leedongwei]

Step 1

Step 2

Step 3

[cursor]

Bug: Detector Filter Key Definition Regression

The fieldDefinitionGetter in DetectorSearch was incorrectly changed from the custom getDetectorFilterKeyDefinition to the generic getFieldDefinition. The original function was specifically designed to create FieldDefinition objects for DETECTOR_FILTER_KEYS (e.g., 'name', 'type', 'assignee') by extracting their specific properties. The generic getFieldDefinition lacks knowledge of these detector-specific keys, preventing the SearchQueryBuilder from properly recognizing and handling them, thus breaking search functionality for detector-specific filters.

static/app/views/detectors/components/detectorSearch.tsx#L21-L22

sentry/static/app/views/detectors/components/detectorSearch.tsx

Lines 21 to 22 in 7894e87

	searchSource="detectors-list"
	fieldDefinitionGetter={getFieldDefinition}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[saponifi3d]

nice! mind adding a few tests as well?

[saponifi3d]

nit: felt like it was a little more concise using entries rather than keys and then inlining the checks for isAssignee.

export function useDetectorFilterKeys(): TagCollection {
  const assignedValues = useAssignedSearchValues();

  return useMemo(() => {
    return Object.fromEntries(
      Object.entries(DETECTOR_FILTER_KEYS).map(([key, config]) => {
        const { values } = config ?? {};
        const isAssignee = key === 'assignee';
        
        return [key, {
          key,
          name: key,
          predefined: isAssignee || values !== undefined,
          values: isAssignee ? assignedValues : values,
        }];
      })
    );
  }, [assignedValues]);
}