Deduplicate TID and lockset in access output with creationLockset

[sim642]

While reviewing #1928 I inspected the current access output of the creationLockset analysis to understand why it wasn't precise enough.
While doing so, I noticed that the TID and lockset are printed twice in access output because they are queried from other analyses which are already responsible for outputting those parts.

On a side note, I'm wondering if should_print could be refined further. For example,

creationLockset:{
                [main] -> {}
              }

is a non-empty map, but only containing empty locksets. That can't really rule out any races, can it?

[dabund24]

While doing so, I noticed that the TID and lockset are printed twice in access output because they are queried from other analyses which are already responsible for outputting those parts.

I agree that your modification makes much more sense. I hadn't put enough thought into that.

[Copilot]

Pull request overview

This PR removes duplicate output of TID and lockset components in the creationLockset analysis access output. The TID and lockset are already printed by the threadid and mutex analyses respectively, so printing them again in creationLockset analysis is redundant.

Changes:

• Override pretty-printing methods (pretty, show, to_yojson, printXml) in the Access module to only output the creation lockset component, delegating to the G module's implementations

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.