Skip to content

Deduplicate TID and lockset in access output with creationLockset #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sim642 merged 2 commits into from
Jan 26, 2026
+7 −1
Merged

Deduplicate TID and lockset in access output with creationLockset #1931

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5ce9a4
Deduplicate TID and lockset in access output with creationLockset
sim642 Jan 23, 2026
b32b613
Refine creationLocksets access `should_print`
sim642 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/analyses/creationLockset.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,13 @@ module Spec = struct
|| one_protected_inter_threaded_other_intra_threaded cl1 t2 ls2
|| one_protected_inter_threaded_other_intra_threaded cl2 t1 ls1)

let should_print (_t, _ls, cl) = not @@ G.is_empty cl
(* TID and Lockset components are directly queried from other analyses and already are printed by them *)
let pretty () (_, _, cl) = G.pretty () cl
let show (_, _, cl) = G.show cl
let to_yojson (_, _, cl) = G.to_yojson cl
let printXml f (_, _, cl) = G.printXml f cl

let should_print (_t, _ls, cl) = G.exists (fun _ ls -> not @@ Lockset.is_empty ls) cl
end

let access man _ =
Expand Down
Loading